Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

message_list: Reduce _RENDER_WINDOW_SIZE to 250. 

The message feed can take long enough to render that
users are locked out of clicking things for a second
or so. This has become especially an issue since we
updated the search bar logic to refresh the message
feed as search terms are added to the search bar.

More details on CZO here:
https://chat.zulip.org/#narrow/stream/101-design/topic/search.20narrow.20live.20update

(cherry picked from commit 9b78cc3240)
This commit is contained in:
evykassirer 2024-07-23 18:09:57 -07:00 committed by Tim Abbott
parent 521c739a93
commit c5bce5c59a
2 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/message_list_view.js
View File

@ -371,7 +371,7 @@ export class MessageListView {
}
// Number of messages to render at a time
_RENDER_WINDOW_SIZE = 400;
_RENDER_WINDOW_SIZE = 250;
// Number of messages away from edge of render window at which we
// trigger a re-render
_RENDER_THRESHOLD = 50;

36
web/tests/message_list_view.test.js
View File

@ -764,7 +764,7 @@ test("render_windows", ({mock_template}) => {
}
function verify_no_move_range(start, end) {
// In our render window, there are up to 300 positions in
// In our render window, there are up to 150 positions in
// the list (with potentially 50 at the start if the range
// starts with 0) where we can move the pointer without forcing
// a re-render. The code avoids hasty re-renders for
@ -788,11 +788,11 @@ test("render_windows", ({mock_template}) => {
}
function verify_move_and_no_move_range(move_target, opts = {}) {
// When we move to position X, we expect 400/2 = 200 messages on
// When we move to position X, we expect 250/2 = 125 messages on
// either side, unless that goes outside the `count`, in which
// case we'll specify it in `opts`.
const move_start = opts.move_start ?? move_target - 200;
const move_end = opts.move_end ?? move_target + 200;
const move_start = opts.move_start ?? move_target - 125;
const move_end = opts.move_end ?? move_target + 125;
verify_move(move_target, [move_start, move_end]);
// the no-move range is a 50 buffer on each side
const no_move_start = opts.no_move_start ?? move_start + 50;
@ -804,19 +804,19 @@ test("render_windows", ({mock_template}) => {
verify_no_move_range(0, 51); // This is the whole list
reset_list({count: 450});
// 400 messages rendered, with the last 50 in the move range
verify_no_move_range(0, 350);
// 250 messages rendered, with the last 50 in the move range
verify_no_move_range(0, 200);
verify_move_and_no_move_range(350, {
// top maxes out at 450
move_end: 450,
});
// We load more than 200 on the upper end, because we load the full 400
// messages and 199 is less than half of that.
verify_move_and_no_move_range(199, {
// We load more than 125 on the upper end, because we load the full 250
// messages and 124 is less than half of that.
verify_move_and_no_move_range(124, {
move_start: 0,
move_end: 400,
move_end: 250,
});
verify_move_and_no_move_range(350, {
@ -824,9 +824,9 @@ test("render_windows", ({mock_template}) => {
move_end: 450,
});
verify_move_and_no_move_range(199, {
verify_move_and_no_move_range(124, {
move_start: 0,
move_end: 400,
move_end: 250,
// The first 50 aren't in a move range, because we can't load earlier
// messages than 0.
no_move_start: 0,
@ -838,13 +838,13 @@ test("render_windows", ({mock_template}) => {
});
reset_list({count: 800});
verify_no_move_range(0, 350);
verify_no_move_range(0, 200);
verify_move_and_no_move_range(350);
verify_move_and_no_move_range(500);
verify_move_and_no_move_range(650, {
verify_move_and_no_move_range(750, {
// top maxes out at 800
move_end: 800,
});
@ -853,11 +853,11 @@ test("render_windows", ({mock_template}) => {
verify_move_and_no_move_range(348);
// We load more than 200 on the upper end, because we load the full 400
// messages and 197 is less than half of that.
verify_move_and_no_move_range(197, {
// We load more than 125 on the upper end, because we load the full 250
// messages and 122 is less than half of that.
verify_move_and_no_move_range(122, {
move_start: 0,
move_end: 400,
move_end: 250,
no_move_start: 0,
});
});