Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

people: Fix TypeScript noUncheckedIndexedAccess errors. 

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2024-05-30 10:07:59 -07:00
parent df849b294a
commit c2c17dcd14
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
web/src/people.ts
View File

@ -621,7 +621,7 @@ export function pm_perma_link(message: Message): string | undefined {
export function pm_with_url(message: Message | MessageWithBooleans): string | undefined { export function pm_with_url(message: Message | MessageWithBooleans): string | undefined {
const user_ids = pm_with_user_ids(message); const user_ids = pm_with_user_ids(message);
if (!user_ids) { if (user_ids?.[0] === undefined) {
return undefined; return undefined;
} }
@ -710,7 +710,7 @@ export function emails_to_slug(emails_string: string): string | undefined {
const emails = emails_string.split(","); const emails = emails_string.split(",");
if (emails.length === 1) { if (emails.length === 1 && emails[0] !== undefined) {
const person = get_by_email(emails[0]); const person = get_by_email(emails[0]);
assert(person !== undefined, "Unknown person in emails_to_slug"); assert(person !== undefined, "Unknown person in emails_to_slug");
const name = person.full_name; const name = person.full_name;
@ -807,6 +807,7 @@ export function user_can_direct_message(recipient_ids_string: string): boolean {
const recipient_ids = user_ids_string_to_ids_array(recipient_ids_string); const recipient_ids = user_ids_string_to_ids_array(recipient_ids_string);
if ( if (
recipient_ids.length === 1 && recipient_ids.length === 1 &&
recipient_ids[0] !== undefined &&
(is_valid_bot_user(recipient_ids[0]) || is_my_user_id(recipient_ids[0])) (is_valid_bot_user(recipient_ids[0]) || is_my_user_id(recipient_ids[0]))
) { ) {
return true; return true;