Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings: Change hover behavior of save discard buttons. 

This commit fixes the hover behavior of save-discard button
in dark theme. We change the text to be slightly brighter
on hover and keep the icon color same.

The background-color property is removed from hover CSS. This
change is safe because for save-button, we already define
different hover behavior below which takes precedence. And
for light-theme, the discard button already has the same
background-color without hovering, so this property was only
affecting discard button in dark-theme.
This commit is contained in:
Sahil Batra 2023-01-05 19:44:39 +05:30 committed by Tim Abbott
parent e804795fa6
commit c0e2c9b6d6
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
static/styles/app_components.css
View File

@ -762,7 +762,6 @@ div.overlay {
&:hover,
&:focus {
background-color: hsl(0, 0%, 100%);
border: 1px solid hsl(0, 0%, 61%);
color: hsl(0, 0%, 18%);

8
static/styles/dark_theme.css
View File

@ -1402,7 +1402,13 @@
#settings_page,
#stream_settings {
.save-button-controls .discard-button {
color: inherit;
color: hsl(0, 0%, 80%);
&:hover {
.save-discard-widget-button-text {
color: hsl(0, 0%, 100%);
}
}
}
}
}