Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

popover_menus: Don't hide on scroll / resize. 

Tippyjs is equipped to handle reference element moving from
its initial position so that the popover moves / changes
along with the reference / window size.
This commit is contained in:
Aman Agrawal 2023-10-24 04:28:01 +00:00 committed by Tim Abbott
parent d08d287431
commit bee8ce4e56
3 changed files with 0 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/message_viewport.js
View File

@ -3,7 +3,6 @@ import $ from "jquery";
import * as blueslip from "./blueslip";
import * as message_lists from "./message_lists";
import * as message_scroll_state from "./message_scroll_state";
import * as popover_menus from "./popover_menus";
import * as rows from "./rows";
import * as util from "./util";
@ -403,7 +402,6 @@ export function maybe_scroll_to_show_message_top() {
const message_height = $selected_message.outerHeight(true) ?? 0;
if (message_top < viewport_info.visible_top) {
set_message_position(message_top, message_height, viewport_info, 0);
popover_menus.set_suppress_scroll_hide();
}
}

32
web/src/popover_menus.js
View File

@ -11,17 +11,6 @@ import * as modals from "./modals";
import * as overlays from "./overlays";
import * as popovers from "./popovers";
// On mobile web, opening the keyboard can trigger a resize event
// (which in turn can trigger a scroll event). This will have the
// side effect of closing popovers, which we don't want. So we
// suppress the first hide from scrolling after a resize using this
// variable.
let suppress_scroll_hide = false;
export function set_suppress_scroll_hide() {
suppress_scroll_hide = true;
}
export const popover_instances = {
compose_control_buttons: null,
starred_messages: null,
@ -288,25 +277,4 @@ export function initialize() {
overlays.register_pre_close_hook(popovers.hide_all);
modals.register_pre_open_hook(popovers.hide_all);
modals.register_pre_close_hook(popovers.hide_all);
let last_scroll = 0;
$(document).on("scroll", () => {
if (suppress_scroll_hide) {
suppress_scroll_hide = false;
return;
}
const date = Date.now();
// only run `popovers.hide_all()` if the last scroll was more
// than 250ms ago.
if (date - last_scroll > 250) {
popovers.hide_all();
}
// update the scroll time on every event to make sure it doesn't
// retrigger `hide_all` while still scrolling.
last_scroll = date;
});
}

10
web/src/resize_handler.js
View File

@ -4,8 +4,6 @@ import * as compose_ui from "./compose_ui";
import * as condense from "./condense";
import * as message_lists from "./message_lists";
import * as message_viewport from "./message_viewport";
import * as popover_menus from "./popover_menus";
import * as popovers from "./popovers";
import * as resize from "./resize";
import * as sidebar_ui from "./sidebar_ui";
import * as util from "./util";
@ -15,13 +13,9 @@ export let _old_width = $(window).width();
export function handler() {
const new_width = $(window).width();
// On mobile web, we want to avoid hiding a popover here on height change,
// especially if this resize was triggered by a virtual keyboard
// popping up when the user opened that very popover.
const mobile = util.is_mobile();
if (!mobile || new_width !== _old_width) {
sidebar_ui.hide_all();
popovers.hide_all();
}
if (new_width !== _old_width) {
@ -38,10 +32,6 @@ export function handler() {
// but before we've loaded in the messages; in that case, don't
// try to scroll to one.
if (message_lists.current.selected_id() !== -1) {
if (mobile) {
popover_menus.set_suppress_scroll_hide();
}
message_viewport.scroll_to_selected();
}
}