Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Disable compose fading for incomplete/wrong stream names 

(imported from commit 2b6a0dbcd1464767e24704f270eeac2875be0d51)
This commit is contained in:
Steve Howell 2013-09-24 11:16:47 -04:00
parent 0d897c469d
commit be9eea6cd4
1 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
static/js/compose_fade.js
View File

@ -116,8 +116,23 @@ function _want_normal_display() {
}
// If the user really hasn't specified anything let, then we want a normal display
if ((focused_recipient.type === "stream" && focused_recipient.subject === "") ||
(focused_recipient.type === "private" && focused_recipient.reply_to === "")) {
if (focused_recipient.type === "stream") {
// If a stream doesn't exist, there is no real chance of a mix, so fading
// is just noise to the user.
if (!stream_data.get_sub(focused_recipient.stream)) {
return true;
}
// This is kind of debatable. If the topic is empty, it could be that
// the user simply hasn't started typing it yet, but disabling fading here
// means the feature doesn't help realms where topics aren't mandatory
// (which is most realms as of this writing).
if (focused_recipient.subject === "") {
return true;
}
}
if (focused_recipient.type === "private" && focused_recipient.reply_to === "") {
return true;
}