Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

upload_widget: Use img tag for tail-spin.svg instead of object tag. 

We use img tag for showing the loading spinner in image_upload_widget
instead of object tag because using object tag gives the following
error "Refused to display 'https://chat.zulip.org/' in a frame because
it set 'X-Frame-Options' to 'deny'." in console.

As mentioned by Anders in czo, this is probably because we’re loading
the SVG using an <object> tag as if it’s totally-not-an-IE3-ActiveX-
control.

Discussed in #issues > loading tail-spin.svg denied by X-Frame-Options.
This commit is contained in:
sahil839 2021-07-16 14:45:47 +05:30 committed by Tim Abbott
parent 989d14299c
commit be8e7fdfb6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
static/templates/settings/image_upload_widget.hbs
View File

@ -11,7 +11,7 @@
{{ upload_text }} {{ upload_text }}
</span> </span>
<span class="upload-spinner-background"> <span class="upload-spinner-background">
<object class="image_upload_spinner" type="image/svg+xml" data="/static/images/tail-spin.svg"></object> <img class="image_upload_spinner" src="/static/images/tail-spin.svg" alt="" />
</span> </span>
</div> </div>
<img class="image-block" src="{{ image }}"/> <img class="image-block" src="{{ image }}"/>