From bdaeccbca14b6afe07f2f183454793386aef90f0 Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Tue, 1 Jan 2019 21:04:23 -0800 Subject: [PATCH] custom profile fields: Remove unnecessary JSON parsing step. Apparently, our custom profile fields feature was parsing the "user list" field type in multiple places, and ignoring the results in one of them. That code had been causing some confusion; the correct solution is to just delete it, since the template rendering process ignores that value for this field type. --- static/js/settings_account.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/static/js/settings_account.js b/static/js/settings_account.js index 494c587cfb..e123e5c415 100644 --- a/static/js/settings_account.js +++ b/static/js/settings_account.js @@ -96,9 +96,6 @@ exports.append_custom_profile_fields = function (element_id, user_id) { } else if (field_type === field_types.URL.id) { type = "url"; } else if (is_user_field) { - if (value) { - value = JSON.parse(value); - } type = "user"; } else { blueslip.error("Undefined field type.");