From bd7deed6917a6a7c16e394b16a34c2b257ad9f11 Mon Sep 17 00:00:00 2001 From: Alex Vandiver Date: Wed, 5 Jan 2022 00:40:32 +0000 Subject: [PATCH] upgrade: Show output from (re)starting zulip. 5c450afd2dc1, in ancient history, switched from `check_call` to `check_output` and throwing away its result. Use check_call, so that we show the steps to (re)starting the server. --- scripts/lib/upgrade-zulip-stage-2 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/lib/upgrade-zulip-stage-2 b/scripts/lib/upgrade-zulip-stage-2 index 26877ebcfe..23747f350f 100755 --- a/scripts/lib/upgrade-zulip-stage-2 +++ b/scripts/lib/upgrade-zulip-stage-2 @@ -351,9 +351,9 @@ if IS_SERVER_UP or not args.skip_puppet: restart_args.append("--skip-tornado") if args.less_graceful: restart_args.append("--less-graceful") - subprocess.check_output(["./scripts/restart-server", *restart_args], preexec_fn=su_to_zulip) + subprocess.check_call(["./scripts/restart-server", *restart_args], preexec_fn=su_to_zulip) else: - subprocess.check_output(["./scripts/start-server", "--fill-cache"], preexec_fn=su_to_zulip) + subprocess.check_call(["./scripts/start-server", "--fill-cache"], preexec_fn=su_to_zulip) logging.info("Upgrade complete!")