Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings_realm_user_settings_default: Convert module to typescript.

This commit is contained in:
evykassirer 2024-11-04 22:38:45 -08:00 committed by Tim Abbott
parent cd701c8468
commit bd10923f13
2 changed files with 27 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/test-js-with-node
View File

@ -225,7 +225,7 @@ EXEMPT_FILES = make_set(
"web/src/settings_preferences.ts", "web/src/settings_preferences.ts",
"web/src/settings_profile_fields.ts", "web/src/settings_profile_fields.ts",
"web/src/settings_realm_domains.ts", "web/src/settings_realm_domains.ts",
"web/src/settings_realm_user_settings_defaults.js", "web/src/settings_realm_user_settings_defaults.ts",
"web/src/settings_sections.js", "web/src/settings_sections.js",
"web/src/settings_streams.ts", "web/src/settings_streams.ts",
"web/src/settings_toggle.js", "web/src/settings_toggle.js",

42
web/src/settings_realm_user_settings_defaults.js → web/src/settings_realm_user_settings_defaults.ts
View File

@ -1,4 +1,5 @@
import $ from "jquery"; import $ from "jquery";
import assert from "minimalistic-assert";
import * as audible_notifications from "./audible_notifications"; import * as audible_notifications from "./audible_notifications";
import { import {
@ -11,11 +12,14 @@ import {realm_user_settings_defaults} from "./realm_user_settings_defaults";
import * as settings_notifications from "./settings_notifications"; import * as settings_notifications from "./settings_notifications";
import * as settings_org from "./settings_org"; import * as settings_org from "./settings_org";
import * as settings_preferences from "./settings_preferences"; import * as settings_preferences from "./settings_preferences";
import type {SettingsPanel} from "./settings_preferences";
import {current_user} from "./state_data"; import {current_user} from "./state_data";
import type {HTMLSelectOneElement} from "./types";
import * as util from "./util";
export const realm_default_settings_panel = {}; export let realm_default_settings_panel: SettingsPanel | undefined;
export function maybe_disable_widgets() { export function maybe_disable_widgets(): void {
if (!current_user.is_admin) { if (!current_user.is_admin) {
$(".organization-box [data-name='organization-level-user-defaults']") $(".organization-box [data-name='organization-level-user-defaults']")
.find("input, select") .find("input, select")
@ -32,7 +36,7 @@ export function maybe_disable_widgets() {
} }
} }
export function update_page(property) { export function update_page(property: string): void {
if (!overlays.settings_open()) { if (!overlays.settings_open()) {
return; return;
} }
@ -41,17 +45,22 @@ export function update_page(property) {
if ($element.length) { if ($element.length) {
const $subsection = $element.closest(".settings-subsection-parent"); const $subsection = $element.closest(".settings-subsection-parent");
if ($subsection.find(".save-button-controls").hasClass("hide")) { if ($subsection.find(".save-button-controls").hasClass("hide")) {
settings_org.discard_realm_default_property_element_changes($element[0]); settings_org.discard_realm_default_property_element_changes(util.the($element));
} else { } else {
settings_org.discard_realm_default_settings_subsection_changes($subsection); settings_org.discard_realm_default_settings_subsection_changes($subsection);
} }
} }
} }
export function set_up() { export function set_up(): void {
assert(realm_default_settings_panel !== undefined);
const $container = $(realm_default_settings_panel.container); const $container = $(realm_default_settings_panel.container);
const $notification_sound_elem = $("audio#realm-default-notification-sound-audio"); const $notification_sound_elem = $<HTMLAudioElement>(
const $notification_sound_dropdown = $container.find(".setting_notification_sound"); "audio#realm-default-notification-sound-audio",
);
const $notification_sound_dropdown = $container.find<HTMLSelectOneElement>(
".setting_notification_sound",
);
settings_preferences.set_up(realm_default_settings_panel); settings_preferences.set_up(realm_default_settings_panel);
@ -61,15 +70,15 @@ export function set_up() {
); );
$notification_sound_dropdown.on("change", () => { $notification_sound_dropdown.on("change", () => {
const sound = $notification_sound_dropdown.val().toLowerCase(); const sound = $notification_sound_dropdown.val()!.toLowerCase();
audible_notifications.update_notification_sound_source($notification_sound_elem, { audible_notifications.update_notification_sound_source($notification_sound_elem, {
notification_sound: sound, notification_sound: sound,
}); });
}); });
if (!page_params.development_environment) { if (!page_params.development_environment) {
$("#realm_dense_mode").on("change", (e) => { $<HTMLInputElement>("#realm_dense_mode").on("change", function (this: HTMLInputElement) {
const val = $(e.target).prop("checked"); const val = this.checked;
if (val) { if (val) {
$container.find(".information-density-settings").hide(); $container.find(".information-density-settings").hide();
return; return;
@ -99,10 +108,11 @@ export function set_up() {
maybe_disable_widgets(); maybe_disable_widgets();
} }
export function initialize() { export function initialize(): void {
realm_default_settings_panel.container = "#realm-user-default-settings"; realm_default_settings_panel = {
realm_default_settings_panel.settings_object = realm_user_settings_defaults; container: "#realm-user-default-settings",
realm_default_settings_panel.notification_sound_elem = settings_object: realm_user_settings_defaults,
"audio#realm-default-notification-sound-audio"; notification_sound_elem: "audio#realm-default-notification-sound-audio",
realm_default_settings_panel.for_realm_settings = true; for_realm_settings: true,
};
} }