Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

do_update_embedded_data: Change send_event to send_event_on_commit. 

Earlier, we were using 'send_event' which can lead to a situation
where we enqueue events but the transaction fails at a later stage.

Events should not be sent until we know we're not rolling back.
This commit is contained in:
Prakhar Pratyush 2024-05-24 13:04:34 +05:30 committed by Tim Abbott
parent 29048bf19a
commit bca8338ee1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/actions/message_edit.py
View File

@ -81,7 +81,7 @@ from zerver.models import (
)
from zerver.models.streams import get_stream_by_id_in_realm
from zerver.models.users import get_system_bot
from zerver.tornado.django_api import send_event
from zerver.tornado.django_api import send_event, send_event_on_commit
def subscriber_info(user_id: int) -> Dict[str, Any]:
@ -363,7 +363,7 @@ def do_update_embedded_data(
"flags": um.flags_list(),
}
send_event(user_profile.realm, event, list(map(user_info, ums)))
send_event_on_commit(user_profile.realm, event, list(map(user_info, ums)))
def get_visibility_policy_after_merge(