Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings: Refactor get_realm_time_limits_in_minutes. 

THis commit refactors get_realm_time_limits_in_minutes
code to not convert the setting value to integer and just
keep it string. This change will help us in not defining
the type of the variable as "number | string" when we can
easily use the string values.
This commit is contained in:
Sahil Batra 2024-02-08 15:48:36 +05:30 committed by Tim Abbott
parent b79040d752
commit bb2a574aa8
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
web/src/settings_components.js
View File

@ -38,15 +38,16 @@ export function get_sorted_options_list(option_values_object) {
} }
export function get_realm_time_limits_in_minutes(property) { export function get_realm_time_limits_in_minutes(property) {
if (realm[property] === null) { const setting_value = realm[property];
if (setting_value === null) {
// This represents "Anytime" case. // This represents "Anytime" case.
return ""; return "";
} }
let val = (realm[property] / 60).toFixed(1); let val = (setting_value / 60).toFixed(1);
if (Number.parseFloat(val) === Number.parseInt(val, 10)) { if (Number.parseFloat(val) === Number.parseInt(val, 10)) {
val = Number.parseInt(val, 10); val = (setting_value / 60).toFixed(0);
} }
return val.toString(); return val;
} }
export function get_property_value(property_name, for_realm_default_settings, sub, group) { export function get_property_value(property_name, for_realm_default_settings, sub, group) {