Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

search: Include history for is:resolved queries. 

The previous logic assumed that all `is:` operators were those like `is:muted`
or `is:starred`, which depend on personal data.
This commit is contained in:
Kenneth Rodrigues 2024-05-21 03:07:08 +05:30 committed by GitHub
parent ffb182fb25
commit ba92cd8b23
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/lib/narrow.py
View File

@ -903,7 +903,7 @@ def ok_to_include_history(
# that's a property on the UserMessage table. There cannot be # that's a property on the UserMessage table. There cannot be
# historical messages in these cases anyway. # historical messages in these cases anyway.
for term in narrow: for term in narrow:
if term["operator"] == "is": if term["operator"] == "is" and term["operand"] not in {"resolved"}:
include_history = False include_history = False
return include_history return include_history

2
zerver/tests/test_message_fetch.py
View File

@ -1103,7 +1103,7 @@ class IncludeHistoryTest(ZulipTestCase):
dict(operator="channels", operand="public"), dict(operator="channels", operand="public"),
dict(operator="is", operand="resolved"), dict(operator="is", operand="resolved"),
] ]
self.assertFalse(ok_to_include_history(narrow, user_profile, False)) self.assertTrue(ok_to_include_history(narrow, user_profile, False))
# simple True case # simple True case
narrow = [ narrow = [