Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

message_fetch: Fix home_msg_list older FetchStatus tracking. 

Apparently, the older side of the FetchStatus object for home_msg_list
was incorrectly not being maintained.  We got away with this, because
the do_backfill code path (which runs after we're done with the
load_more cycle) will correct the error for found_oldest.  But we
didn't have proper handling for history_limited here.
This commit is contained in:
Tim Abbott 2018-12-12 15:41:57 -08:00
parent ba6ef745fe
commit b8a45d889e
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
static/js/message_fetch.js
View File

@ -56,7 +56,7 @@ function process_result(data, opts) {
stream_list.maybe_scroll_narrow_into_view();
if (opts.cont !== undefined) {
opts.cont(data);
opts.cont(data, opts);
}
}
@ -289,7 +289,7 @@ exports.start_backfilling_messages = function () {
exports.initialize = function () {
// get the initial message list
function load_more(data) {
function load_more(data, opts) {
// If we received the initially selected message, select it on the client side,
// but not if the user has already selected another one during load.
//
@ -301,6 +301,17 @@ exports.initialize = function () {
target_scroll_offset: page_params.initial_offset});
}
if (opts.num_before > 0) {
// Only the initial call with num_before=consts.num_before_pointer
// has an older batch to finish.
home_msg_list.fetch_status.finish_older_batch({
found_oldest: data.found_oldest,
});
message_list.all.fetch_status.finish_older_batch({
found_oldest: data.found_oldest,
});
}
home_msg_list.fetch_status.finish_newer_batch({
found_newest: data.found_newest,
});
@ -335,6 +346,8 @@ exports.initialize = function () {
if (page_params.have_initial_messages) {
home_msg_list.fetch_status.start_newer_batch();
message_list.all.fetch_status.start_newer_batch();
home_msg_list.fetch_status.start_older_batch();
message_list.all.fetch_status.start_older_batch();
exports.load_messages({
anchor: page_params.pointer,
num_before: consts.num_before_pointer,