Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings_org: Extract get_input_element_value function. 

The reason for extracting this function is that getting the text, integer,
boolean value from the input elements (like checkboxes, dropdowns) is a
common task, and later we can use this function to get the input element
value in `settings_notifications` in the upcoming commit.
This commit is contained in:
Pragati Agrawal 2020-03-22 20:43:50 +05:30 committed by Tim Abbott
parent f439bd7c36
commit b8945bafb4
1 changed files with 20 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
static/js/settings_org.js
View File

@ -525,6 +525,23 @@ exports.change_save_button_state = function ($element, state) {
show_hide_element($element, is_show, 800); show_hide_element($element, is_show, 800);
}; };
exports.get_input_element_value = function (input_elem) {
input_elem = $(input_elem);
const input_type = input_elem.data("setting-widget-type");
if (input_type) {
if (input_type === 'bool') {
return input_elem.prop('checked');
}
if (input_type === 'text') {
return input_elem.val().trim();
}
if (input_type === 'integer') {
return parseInt(input_elem.val().trim(), 10);
}
}
return null;
};
exports.set_up = function () { exports.set_up = function () {
exports.build_page(); exports.build_page();
exports.maybe_disable_widgets(); exports.maybe_disable_widgets();
@ -770,20 +787,10 @@ exports.build_page = function () {
for (let input_elem of properties_elements) { for (let input_elem of properties_elements) {
input_elem = $(input_elem); input_elem = $(input_elem);
if (check_property_changed(input_elem)) { if (check_property_changed(input_elem)) {
const input_type = input_elem.data("setting-widget-type"); const input_value = exports.get_input_element_value(input_elem);
if (input_type) { if (input_value) {
const property_name = input_elem.attr('id').replace("id_realm_", ""); const property_name = input_elem.attr('id').replace("id_realm_", "");
if (input_type === 'bool') { data[property_name] = JSON.stringify(input_value);
data[property_name] = JSON.stringify(input_elem.prop('checked'));
continue;
}
if (input_type === 'text') {
data[property_name] = JSON.stringify(input_elem.val().trim());
continue;
}
if (input_type === 'integer') {
data[property_name] = JSON.stringify(parseInt(input_elem.val().trim(), 10));
}
} }
} }
} }