Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

ruff: Fix PLC0208 Use a sequence type when iterating over values. 

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2023-06-06 13:54:42 -07:00
parent b907ad0dcb
commit b7909db987
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/management/commands/add_users_to_streams.py
View File

@ -25,7 +25,7 @@ class Command(ZulipBaseCommand):
user_profiles = self.get_users(options, realm) user_profiles = self.get_users(options, realm)
stream_names = {stream.strip() for stream in options["streams"].split(",")} stream_names = {stream.strip() for stream in options["streams"].split(",")}
for stream_name in set(stream_names): for stream_name in stream_names:
for user_profile in user_profiles: for user_profile in user_profiles:
stream = ensure_stream(realm, stream_name, acting_user=None) stream = ensure_stream(realm, stream_name, acting_user=None)
_ignore, already_subscribed = bulk_add_subscriptions( _ignore, already_subscribed = bulk_add_subscriptions(

2
zerver/management/commands/create_default_stream_groups.py
View File

@ -40,7 +40,7 @@ Create default stream groups which the users can choose during sign up.
streams = [] streams = []
stream_names = {stream.strip() for stream in options["streams"].split(",")} stream_names = {stream.strip() for stream in options["streams"].split(",")}
for stream_name in set(stream_names): for stream_name in stream_names:
stream = ensure_stream(realm, stream_name, acting_user=None) stream = ensure_stream(realm, stream_name, acting_user=None)
streams.append(stream) streams.append(stream)

4
zerver/tests/test_auth_backends.py
View File

@ -1588,7 +1588,7 @@ class SocialAuthBase(DesktopFlowTestingLib, ZulipTestCase, ABC):
stream_names = ["new_stream_1", "new_stream_2"] stream_names = ["new_stream_1", "new_stream_2"]
streams = [] streams = []
for stream_name in set(stream_names): for stream_name in stream_names:
stream = ensure_stream(realm, stream_name, acting_user=None) stream = ensure_stream(realm, stream_name, acting_user=None)
streams.append(stream) streams.append(stream)
@ -4599,7 +4599,7 @@ class GoogleAuthBackendTest(SocialAuthBase):
stream_names = ["new_stream_1", "new_stream_2"] stream_names = ["new_stream_1", "new_stream_2"]
streams = [] streams = []
for stream_name in set(stream_names): for stream_name in stream_names:
stream = ensure_stream(realm, stream_name, acting_user=None) stream = ensure_stream(realm, stream_name, acting_user=None)
streams.append(stream) streams.append(stream)

2
zproject/backends.py
View File

@ -867,7 +867,7 @@ class ZulipLDAPAuthBackendBase(ZulipAuthMixin, LDAPBackend):
if "full_name" in settings.AUTH_LDAP_USER_ATTR_MAP: if "full_name" in settings.AUTH_LDAP_USER_ATTR_MAP:
full_name_attr = settings.AUTH_LDAP_USER_ATTR_MAP["full_name"] full_name_attr = settings.AUTH_LDAP_USER_ATTR_MAP["full_name"]
full_name = ldap_user.attrs[full_name_attr][0] full_name = ldap_user.attrs[full_name_attr][0]
elif all(key in settings.AUTH_LDAP_USER_ATTR_MAP for key in {"first_name", "last_name"}): elif all(key in settings.AUTH_LDAP_USER_ATTR_MAP for key in ["first_name", "last_name"]):
first_name_attr = settings.AUTH_LDAP_USER_ATTR_MAP["first_name"] first_name_attr = settings.AUTH_LDAP_USER_ATTR_MAP["first_name"]
last_name_attr = settings.AUTH_LDAP_USER_ATTR_MAP["last_name"] last_name_attr = settings.AUTH_LDAP_USER_ATTR_MAP["last_name"]
first_name = ldap_user.attrs[first_name_attr][0] first_name = ldap_user.attrs[first_name_attr][0]