Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

navbar_help_menu: Migrate module to typescript. 

Signed-off-by: sayyedarib <sayyedaribhussain4321@gmail.com>
This commit is contained in:
sayyedarib 2023-12-29 12:11:22 +05:30 committed by Anders Kaseorg
parent 2cf8f1c063
commit b430ba2bd5
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/test-js-with-node
View File

@ -152,7 +152,7 @@ EXEMPT_FILES = make_set(
"web/src/narrow_history.ts", "web/src/narrow_history.ts",
"web/src/narrow_title.ts", "web/src/narrow_title.ts",
"web/src/navbar_alerts.js", "web/src/navbar_alerts.js",
"web/src/navbar_help_menu.js", "web/src/navbar_help_menu.ts",
"web/src/navbar_menus.js", "web/src/navbar_menus.js",
"web/src/navigate.js", "web/src/navigate.js",
"web/src/onboarding_steps.js", "web/src/onboarding_steps.js",

6
web/src/navbar_help_menu.js → web/src/navbar_help_menu.ts
View File

@ -6,7 +6,7 @@ import {page_params} from "./page_params";
import * as popover_menus from "./popover_menus"; import * as popover_menus from "./popover_menus";
import {parse_html} from "./ui_util"; import {parse_html} from "./ui_util";
export function initialize() { export function initialize(): void {
popover_menus.register_popover_menu("#help-menu", { popover_menus.register_popover_menu("#help-menu", {
theme: "navbar-dropdown-menu", theme: "navbar-dropdown-menu",
placement: "bottom", placement: "bottom",
@ -39,12 +39,12 @@ export function initialize() {
}, },
onHidden(instance) { onHidden(instance) {
instance.destroy(); instance.destroy();
popover_menus.popover_instances.help_menu = undefined; popover_menus.popover_instances.help_menu = null;
}, },
}); });
} }
export function toggle() { export function toggle(): void {
// NOTE: Since to open help menu, you need to click on help navbar icon (which calls // NOTE: Since to open help menu, you need to click on help navbar icon (which calls
// tippyjs.hideAll()), or go via gear menu if using hotkeys, we don't need to // tippyjs.hideAll()), or go via gear menu if using hotkeys, we don't need to
// call tippyjs.hideAll() for it. // call tippyjs.hideAll() for it.