Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

css: Remove use of under-specified 'thin' borders. 

This was causing buggy behavior in our emoji reactions when zoomed to
200%.
This commit is contained in:
Tim Abbott 2017-04-20 15:04:39 -07:00
parent f3c36147d9
commit b3c8562bd9
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
static/styles/reactions.css
View File

@ -78,7 +78,7 @@
}
.message_reactions .message_reaction:hover {
border: thin solid #0088CC;
border: 1px solid #0088CC;
}
.message_reactions .reaction_button:only-child {
@ -93,13 +93,13 @@
height: 14px;
border-radius: 4px;
padding-left: 0.3em;
border: thin solid #bbb;
border: 1px solid #bbb;
padding-right: 0.3em;
float: left;
}
.message_reactions .reaction_button:hover {
border: thin solid #0088CC;
border: 1px solid #0088CC;
background-color: #eef7fa;
cursor: pointer;
opacity: 1.0;
@ -153,7 +153,7 @@
margin: 0.1em;
padding: 0.3em;
cursor: pointer;
border: thin solid white;
border: 1px solid white;
border-radius: 0.5em;
}

6
tools/lint-all
View File

@ -463,6 +463,12 @@ def build_custom_checkers(by_lang):
'strip': '\n'},
{'pattern': '{\w',
'description': "Missing whitespace after '{' in CSS (should be newline)."},
{'pattern': ' thin[; ]',
'description': "thin CSS attribute is under-specified, please use 1px."},
{'pattern': ' medium[; ]',
'description': "medium CSS attribute is under-specified, please use pixels."},
{'pattern': ' thick[; ]',
'description': "thick CSS attribute is under-specified, please use pixels."},
]) + whitespace_rules # type: RuleList
prose_style_rules = [
{'pattern': '[^\/\#\-\"]([jJ]avascript)', # exclude usage in hrefs/divs