Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

portico: Fix multiple landing pages broken. 

Since postcss tries to preserve specificity of selectors which
are defined in in a group, a `:not(#does-not-exist)` selector
was added to the non ID selectors (solutions-page and case-study-page).

This caused the CSS styles to override other styles due to
unexpectedly increased specificity.

To fix it, we remove the ID selector `#why-zulip-page` from the
group.
This commit is contained in:
Aman Agrawal 2024-11-18 18:09:10 +05:30 committed by Tim Abbott
parent a8abcf5210
commit b39347a946
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
templates/corporate/why-zulip.html
View File

@ -15,7 +15,7 @@
{% include 'zerver/landing_nav.html' %} {% include 'zerver/landing_nav.html' %}
<div class="portico-landing why-page" id="why-zulip-page"> <div class="portico-landing why-page">
<div class="hero bg-pycon why-zulip"> <div class="hero bg-pycon why-zulip">
<div class="bg-dimmer"></div> <div class="bg-dimmer"></div>
<div class="content"> <div class="content">

4
web/styles/portico/landing_page.css
View File

@ -2402,7 +2402,7 @@ button {
border-left: 6px solid hsl(168.1deg 49.15% 46.27%); border-left: 6px solid hsl(168.1deg 49.15% 46.27%);
} }
#why-zulip-page, .why-page,
.case-study-page, .case-study-page,
.solutions-page { .solutions-page {
.bottom-register-buttons.extra_margin_before_footer { .bottom-register-buttons.extra_margin_before_footer {
@ -2692,7 +2692,7 @@ button {
} }
.self-hosting-page, .self-hosting-page,
#why-zulip-page { .why-page {
.hero-buttons { .hero-buttons {
margin-top: 30px; margin-top: 30px;
} }