notifications: Revert API changes for push_notifications_enabled.

This commit reverts the API changes in 56ec1c2.

api_docs/changelog.md

@@ -20,13 +20,6 @@ format used by the Zulip server that they are interacting with.
 
 ## Changes in Zulip 8.0
 
-**Feature level 231**
-
-* [`GET /server_settings`](/api/get-server-settings): Renamed
-`push_notifications_enabled` to `push_notifications_configured`
- as it doesn't actually check if push notifications are working,
- just whether there is configuration for them.
-
 **Feature level 230**
 
 * [`GET /events`](/api/get-events): Added `has_trigger` field in

version.py

@@ -33,7 +33,7 @@ DESKTOP_WARNING_VERSION = "5.9.3"
 # Changes should be accompanied by documentation explaining what the
 # new level means in api_docs/changelog.md, as well as "**Changes**"
 # entries in the endpoint's documentation in `zulip.yaml`.
-API_FEATURE_LEVEL = 231
+API_FEATURE_LEVEL = 230
 
 # Bump the minor PROVISION_VERSION to indicate that folks should provision
 # only when going from an old version of the code to a newer version. Bump

zerver/openapi/zulip.yaml

@@ -15624,13 +15624,10 @@ paths:
                           This will be `""` if unavailable.
 
                           **Changes**: New in Zulip 5.0 (feature level 88).
-                      push_notifications_configured:
+                      push_notifications_enabled:
                         type: boolean
                         description: |
                           Whether mobile/push notifications are configured.
-
-                          **Changes**: In Zulip 8.0 (feature level 231), renamed
-                          `push_notifications_enabled` to `push_notifications_configured`.
                       is_incompatible:
                         type: boolean
                         description: |
@@ -15701,7 +15698,7 @@ paths:
                           },
                         "zulip_version": "5.0-dev-1650-gc3fd37755f",
                         "zulip_merge_base": "5.0-dev-1646-gea6b21cd8c",
-                        "push_notifications_configured": false,
+                        "push_notifications_enabled": false,
                         "msg": "",
                         "is_incompatible": false,
                         "email_auth_enabled": true,

zerver/tests/test_auth_backends.py

@@ -5248,7 +5248,7 @@ class FetchAuthBackends(ZulipTestCase):
                     ("zulip_version", check_string),
                     ("zulip_merge_base", check_string),
                     ("zulip_feature_level", check_int),
-                    ("push_notifications_configured", check_bool),
+                    ("push_notifications_enabled", check_bool),
                     ("realm_web_public_access_enabled", check_bool),
                     ("msg", check_string),
                     ("result", check_string),

zerver/views/auth.py

@@ -1109,7 +1109,7 @@ def api_get_server_settings(request: HttpRequest) -> HttpResponse:
         zulip_version=ZULIP_VERSION,
         zulip_merge_base=ZULIP_MERGE_BASE,
         zulip_feature_level=API_FEATURE_LEVEL,
-        push_notifications_configured=push_notifications_configured(),
+        push_notifications_enabled=push_notifications_configured(),
         is_incompatible=check_server_incompatibility(request),
     )
     context = zulip_default_context(request)