Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

tests: Treat github.com/zulip links as external. 

Tests for these links often result in rate-limiting from GitHub,
leading to the builds failing in Circle CI. We temporarily mark
github.com/zulip links as external to keep the builds passing.
This commit is contained in:
Rohitt Vashishtha 2020-03-18 23:47:08 +00:00 committed by showell
parent 65f7231dd3
commit b25e02aa14
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/documentation_crawler/documentation_crawler/spiders/common/spiders.py
View File

@ -70,8 +70,10 @@ class BaseDocumentationSpider(scrapy.Spider):
# We also want CI to check any links to built documentation. # We also want CI to check any links to built documentation.
return False return False
if 'github.com/zulip' in url: if 'github.com/zulip' in url:
# Finally, links to our own GitHub organization should always work. # We want to check these links but due to rate limiting from GitHub, these checks often
return False # fail in the CI. Thus, we should treat these as external links for now.
# TODO: Figure out how to test github.com/zulip links in CI.
return True
return True return True
def check_fragment(self, response: Response) -> None: def check_fragment(self, response: Response) -> None: