Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

css: Do not use "*" selector for color_animated_button styles. 

Using "*" selector is inefficient as they require checking every
element because of the browser's bottom-up matching process.
This commit is contained in:
Sahil Batra 2024-07-24 14:37:33 +05:30 committed by Tim Abbott
parent c4c9c59a41
commit b0e8096579
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
web/styles/app_components.css
View File

@ -719,7 +719,8 @@ div.overlay {
transition: all 0.2s ease; transition: all 0.2s ease;
} }
* { .zulip-icon,
.color-animated-button-text {
padding: 6px 3px; padding: 6px 3px;
} }

3
web/styles/dark_theme.css
View File

@ -961,7 +961,8 @@
.color_animated_button { .color_animated_button {
background-color: hsl(211deg 29% 14%); background-color: hsl(211deg 29% 14%);
* { .zulip-icon,
.color-animated-button-text {
color: hsl(0deg 0% 100%); color: hsl(0deg 0% 100%);
} }

2
web/templates/login_to_view_image_button.hbs
View File

@ -1,6 +1,6 @@
<div class="spectator_login_for_image_button"> <div class="spectator_login_for_image_button">
<a class="login_button color_animated_button" href="/login/"> <a class="login_button color_animated_button" href="/login/">
<i class='zulip-icon zulip-icon-log-in'></i> <i class='zulip-icon zulip-icon-log-in'></i>
<span>{{t "Log in to view image" }}</span> <span class="color-animated-button-text">{{t "Log in to view image" }}</span>
</a> </a>
</div> </div>