Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

left_sidebar: Redesign combined feed view popover. 

Fixes part of #28699.
This commit is contained in:
Sayam Samal 2024-06-13 12:22:43 +05:30 committed by Tim Abbott
parent 7482f9b0fe
commit b0ae9fedbf
2 changed files with 24 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
web/src/left_sidebar_navigation_area_popovers.js
View File

@ -149,6 +149,7 @@ export function initialize() {
// Combined feed popover
popover_menus.register_popover_menu(".all-messages-sidebar-menu-icon", {
theme: "popover-menu",
...popover_menus.left_sidebar_tippy_options,
onMount(instance) {
const $popper = $(instance.popper);

26
web/templates/popovers/left_sidebar/left_sidebar_all_messages_popover.hbs
View File

@ -1,21 +1,23 @@
<ul class="nav nav-list">
<div class="popover-menu" data-simplebar>
<ul role="menu" class="popover-menu-list">
{{#if is_home_view}}
<li>
{{! tabindex="0" Makes anchor tag focusable. Needed for keyboard support. }}
<a tabindex="0" id="mark_all_messages_as_read">
<i class="fa fa-book" aria-hidden="true"></i>
{{t "Mark all messages as read" }}
<li role="none" class="link-item popover-menu-list-item">
<a role="menuitem" id="mark_all_messages_as_read" class="popover-menu-link" tabindex="0">
<i class="popover-menu-icon zulip-icon zulip-icon-mark-as-read" aria-hidden="true"></i>
<span class="popover-menu-label">{{t "Mark all messages as read" }}</span>
</a>
</li>
{{/if}}
{{#unless is_home_view}}
<li>
<a tabindex="0" class="set-home-view" data-view-code="{{view_code}}">
<i class="fa fa-home" aria-hidden="true"></i>
{{else}}
<li role="none" class="link-item popover-menu-list-item">
<a role="menuitem" class="set-home-view popover-menu-link" data-view-code="{{view_code}}" tabindex="0">
<i class="popover-menu-icon fa fa-home" aria-hidden="true"></i>
<span class="popover-menu-label">
{{#tr}}
Make <b>combined feed</b> my home view
{{/tr}}
</span>
</a>
</li>
{{/unless}}
{{/if}}
</ul>
</div>