Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

tornado: Replace a TODO comment with an explanation.

This commit is contained in:
Alex Vandiver 2023-12-11 21:41:26 +00:00 committed by Tim Abbott
parent 886a86866d
commit b032b2a4da
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
zerver/tornado/handlers.py
View File

@ -210,9 +210,10 @@ class AsyncDjangoHandler(tornado.web.RequestHandler):
# Register a Tornado handler that runs when client-side # Register a Tornado handler that runs when client-side
# connections are closed to notify the events system. # connections are closed to notify the events system.
# #
# TODO: Theoretically, this code should run when you Ctrl-C # Note that in the development environment, the development
# curl to cause it to break a `GET /events` connection, but # proxy does not correctly close connections to Tornado when
# that seems to no longer run this code. Investigate what's up. # its clients (e.g. `curl`) close their connections. This
# code path is thus _unreachable except in production_.
client_descriptor = get_descriptor_by_handler_id(self.handler_id) client_descriptor = get_descriptor_by_handler_id(self.handler_id)
if client_descriptor is not None: if client_descriptor is not None:
client_descriptor.disconnect_handler(client_closed=True) client_descriptor.disconnect_handler(client_closed=True)