From af36e9f8234237eeabcc1cb134b57366e57b9e57 Mon Sep 17 00:00:00 2001 From: Sahil Batra Date: Mon, 26 Dec 2022 15:42:15 +0530 Subject: [PATCH] css: Add "bootstrap-focus-style" class to select elements. This commit adds "bootstrap-focus-style" class to the select elements such that we can add CSS rule for focusing a select element at single place only using this class. --- static/styles/components.css | 8 +++++ static/templates/invite_user.hbs | 6 ++-- static/templates/move_topic_to_stream.hbs | 2 +- .../templates/settings/add_new_bot_form.hbs | 6 ++-- .../add_new_custom_profile_field_form.hbs | 4 +-- .../templates/settings/admin_human_form.hbs | 2 +- .../settings/custom_user_profile_field.hbs | 2 +- .../templates/settings/display_settings.hbs | 8 ++--- .../settings/notification_settings.hbs | 6 ++-- .../organization_permissions_admin.hbs | 36 +++++++++---------- .../settings/organization_profile_admin.hbs | 2 +- .../settings/organization_settings_admin.hbs | 8 ++--- .../templates/settings/profile_settings.hbs | 2 +- .../stream_settings/stream_types.hbs | 4 +-- templates/corporate/upgrade.html | 2 +- templates/zerver/development/dev_login.html | 2 +- .../development/integrations_dev_panel.html | 6 ++-- 17 files changed, 57 insertions(+), 49 deletions(-) diff --git a/static/styles/components.css b/static/styles/components.css index 117d43b580..0b9cc8b2b2 100644 --- a/static/styles/components.css +++ b/static/styles/components.css @@ -136,3 +136,11 @@ input::-ms-reveal { } } } + +select.bootstrap-focus-style { + &:focus { + outline: 1px dotted hsl(0, 0%, 20%); + outline: 5px auto -webkit-focus-ring-color; + outline-offset: -2px; + } +} diff --git a/static/templates/invite_user.hbs b/static/templates/invite_user.hbs index ff211f7eb0..c0b1ecfb8a 100644 --- a/static/templates/invite_user.hbs +++ b/static/templates/invite_user.hbs @@ -32,7 +32,7 @@
- {{#each expires_in_options}} {{/each}} @@ -42,7 +42,7 @@
- {{#each time_choices}} {{/each}} @@ -55,7 +55,7 @@ {{> help_link_widget link="/help/roles-and-permissions" }}
- {{#if is_admin}} diff --git a/static/templates/move_topic_to_stream.hbs b/static/templates/move_topic_to_stream.hbs index 6c31741481..9f8f6210df 100644 --- a/static/templates/move_topic_to_stream.hbs +++ b/static/templates/move_topic_to_stream.hbs @@ -15,7 +15,7 @@ {{#if from_message_actions_popover}} - diff --git a/static/templates/settings/add_new_bot_form.hbs b/static/templates/settings/add_new_bot_form.hbs index 24d8c03006..1f3b46841e 100644 --- a/static/templates/settings/add_new_bot_form.hbs +++ b/static/templates/settings/add_new_bot_form.hbs @@ -5,7 +5,7 @@ {{t "Bot type" }} - {{#each bot_types}} {{#if this.allowed}} @@ -15,7 +15,7 @@
- {{#each realm_embedded_bots}} {{/each}} @@ -45,7 +45,7 @@
- diff --git a/static/templates/settings/add_new_custom_profile_field_form.hbs b/static/templates/settings/add_new_custom_profile_field_form.hbs index 67db10eadc..88c107b0c9 100644 --- a/static/templates/settings/add_new_custom_profile_field_form.hbs +++ b/static/templates/settings/add_new_custom_profile_field_form.hbs @@ -2,7 +2,7 @@
- {{#each custom_profile_field_types}} {{/each}} @@ -10,7 +10,7 @@
- {{#each realm_default_external_accounts}} {{/each}} diff --git a/static/templates/settings/admin_human_form.hbs b/static/templates/settings/admin_human_form.hbs index 120811e2fa..fe55710074 100644 --- a/static/templates/settings/admin_human_form.hbs +++ b/static/templates/settings/admin_human_form.hbs @@ -19,7 +19,7 @@ - {{> dropdown_options_widget option_values=user_role_values}}
diff --git a/static/templates/settings/custom_user_profile_field.hbs b/static/templates/settings/custom_user_profile_field.hbs index 5e10df1f89..2ecf33532b 100644 --- a/static/templates/settings/custom_user_profile_field.hbs +++ b/static/templates/settings/custom_user_profile_field.hbs @@ -6,7 +6,7 @@ {{#if is_long_text_field}} {{else if is_select_field}} - {{#each field_choices}} diff --git a/static/templates/settings/display_settings.hbs b/static/templates/settings/display_settings.hbs index 3ee361effe..7f8b234eca 100644 --- a/static/templates/settings/display_settings.hbs +++ b/static/templates/settings/display_settings.hbs @@ -19,7 +19,7 @@
- {{#each twenty_four_hour_time_values}} {{/each}} @@ -37,7 +37,7 @@
- {{> dropdown_options_widget option_values=color_scheme_values}}
@@ -118,7 +118,7 @@ - {{> dropdown_options_widget option_values=default_view_values}}
@@ -133,7 +133,7 @@ - {{> dropdown_options_widget option_values=demote_inactive_streams_values}}
diff --git a/static/templates/settings/notification_settings.hbs b/static/templates/settings/notification_settings.hbs index 5205bb341c..e14fe924f8 100644 --- a/static/templates/settings/notification_settings.hbs +++ b/static/templates/settings/notification_settings.hbs @@ -73,7 +73,7 @@ {{t "Notification sound" }} -
+
+
@@ -129,7 +129,7 @@ - {{#each email_notifications_batching_period_values}} {{/each}} diff --git a/static/templates/settings/organization_permissions_admin.hbs b/static/templates/settings/organization_permissions_admin.hbs index 1ff6115d15..2538a8a47d 100644 --- a/static/templates/settings/organization_permissions_admin.hbs +++ b/static/templates/settings/organization_permissions_admin.hbs @@ -18,14 +18,14 @@ label=admin_settings_label.realm_invite_required}} - {{> dropdown_options_widget option_values=invite_to_realm_policy_values}}
- @@ -42,7 +42,7 @@ {{t "Waiting period before new members turn into full members" }} {{> ../help_link_widget link="/help/restrict-permissions-of-new-members" }} - {{> dropdown_options_widget option_values=waiting_period_threshold_dropdown_values}} {{!-- This setting is hidden unless `custom_period` --}} @@ -85,7 +85,7 @@ - {{> dropdown_options_widget option_values=email_address_visibility_values}}
@@ -99,7 +99,7 @@
- {{> dropdown_options_widget option_values=common_policy_values}}
@@ -113,19 +113,19 @@ help_link="/help/public-access-option"}}
- {{> dropdown_options_widget option_values=create_web_public_stream_policy_values}}
- {{> dropdown_options_widget option_values=common_policy_values}}
- {{> dropdown_options_widget option_values=common_policy_values}}
@@ -133,7 +133,7 @@ - {{> dropdown_options_widget option_values=wildcard_mention_policy_values}}
@@ -162,7 +162,7 @@
- {{#each msg_edit_limit_dropdown_values}} {{/each}} @@ -191,7 +191,7 @@
- {{> dropdown_options_widget option_values=edit_topic_policy_values}}
@@ -199,7 +199,7 @@
- {{> dropdown_options_widget option_values=move_messages_between_streams_policy_values}}
@@ -220,7 +220,7 @@ - {{> dropdown_options_widget option_values=common_message_policy_values}}
@@ -229,7 +229,7 @@ - {{#each msg_delete_limit_dropdown_values}} {{/each}} @@ -256,21 +256,21 @@
- {{> dropdown_options_widget option_values=bot_creation_policy_values}}
- {{> dropdown_options_widget option_values=common_policy_values}}
- {{> dropdown_options_widget option_values=common_policy_values}}
@@ -279,7 +279,7 @@ - {{> dropdown_options_widget option_values=private_message_policy_values}}
diff --git a/static/templates/settings/organization_profile_admin.hbs b/static/templates/settings/organization_profile_admin.hbs index 5d4c02c7a9..22c370de66 100644 --- a/static/templates/settings/organization_profile_admin.hbs +++ b/static/templates/settings/organization_profile_admin.hbs @@ -21,7 +21,7 @@ - {{> dropdown_options_widget option_values=realm_org_type_values}}
diff --git a/static/templates/settings/organization_settings_admin.hbs b/static/templates/settings/organization_settings_admin.hbs index 240417a1b0..3f4bd24dd7 100644 --- a/static/templates/settings/organization_settings_admin.hbs +++ b/static/templates/settings/organization_settings_admin.hbs @@ -23,7 +23,7 @@ @@ -105,7 +105,7 @@ - {{#each realm_available_video_chat_providers}} {{/each}} @@ -116,7 +116,7 @@ {{t 'GIPHY integration' }} {{> ../help_link_widget link=giphy_help_link }} - {{#each giphy_rating_options}} {{/each}} diff --git a/static/templates/settings/profile_settings.hbs b/static/templates/settings/profile_settings.hbs index 030749614e..2a0083ab27 100644 --- a/static/templates/settings/profile_settings.hbs +++ b/static/templates/settings/profile_settings.hbs @@ -20,7 +20,7 @@
- {{#unless settings_object.timezone}} {{/unless}} diff --git a/static/templates/stream_settings/stream_types.hbs b/static/templates/stream_settings/stream_types.hbs index 2aba113bd5..01da984fa2 100644 --- a/static/templates/stream_settings/stream_types.hbs +++ b/static/templates/stream_settings/stream_types.hbs @@ -31,7 +31,7 @@ - {{#each stream_post_policy_values}}