Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

rendered_markdown: Fix code getting copied when visiting playground. 

Fixes #29844.
This commit is contained in:
nimishmedatwal 2024-04-27 00:27:30 +05:30 committed by Tim Abbott
parent 178d4f364b
commit acf13e49cf
2 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
web/src/rendered_markdown.ts
View File

@ -307,14 +307,15 @@ export const update_elements = ($content: JQuery): void => {
$view_in_playground_button.attr("data-tippy-content", title); $view_in_playground_button.attr("data-tippy-content", title);
$view_in_playground_button.attr("aria-label", title); $view_in_playground_button.attr("aria-label", title);
} }
const $copy_button = $buttonContainer.find(".copy_codeblock");
const clipboard = new ClipboardJS($buttonContainer[0], { const clipboard = new ClipboardJS($copy_button[0], {
text(copy_element) { text(copy_element) {
return $(copy_element).siblings("code").text(); const $code = $(copy_element).parent().siblings("code");
return $code.text();
}, },
}); });
clipboard.on("success", () => { clipboard.on("success", () => {
const $copy_button = $buttonContainer.find(".copy_codeblock");
show_copied_confirmation($copy_button[0]); show_copied_confirmation($copy_button[0]);
}); });
$codehilite.addClass("zulip-code-block"); $codehilite.addClass("zulip-code-block");

14
web/tests/rendered_markdown.test.js
View File

@ -529,12 +529,14 @@ function assert_clipboard_setup() {
assert.equal(clipboard_args[0], "copy-code-stub"); assert.equal(clipboard_args[0], "copy-code-stub");
const text = clipboard_args[1].text({ const text = clipboard_args[1].text({
to_$: () => ({ to_$: () => ({
siblings(arg) { parent: () => ({
assert.equal(arg, "code"); siblings(arg) {
return { assert.equal(arg, "code");
text: () => "text", return {
}; text: () => "text",
}, };
},
}),
}), }),
}); });
assert.equal(text, "text"); assert.equal(text, "text");