Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

search: Rename search_arrows to searchbox_container. 

The terminology "arrows" comes from historical functionality
that is no longer relevant, so searchbox_container is a more
clear and accurate name.

It would be nice in the future to see if we can remove
some of the nesting of HTML (#searchbox, #searchbox_form,
and #searchbox_container).
This commit is contained in:
evykassirer 2023-07-18 12:06:24 -04:00 committed by Tim Abbott
parent 2ae285af7c
commit aa9d5935ae
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/styles/dark_theme.css
View File

@ -525,7 +525,7 @@
background-color: hsl(0deg 0% 0% / 20%); background-color: hsl(0deg 0% 0% / 20%);
} }
#search_arrows .pill, #searchbox-input-container .pill,
#compose-direct-recipient.pill-container .pill { #compose-direct-recipient.pill-container .pill {
color: inherit; color: inherit;
border: 1px solid hsl(0deg 0% 0% / 50%); border: 1px solid hsl(0deg 0% 0% / 50%);
@ -533,7 +533,7 @@
font-weight: 600; font-weight: 600;
} }
#search_arrows .pill:focus, #searchbox-input-container .pill:focus,
#compose-direct-recipient.pill-container .pill:focus { #compose-direct-recipient.pill-container .pill:focus {
color: hsl(0deg 0% 100%); color: hsl(0deg 0% 100%);
border: 1px solid hsl(176deg 78% 28% / 60%); border: 1px solid hsl(176deg 78% 28% / 60%);

4
web/styles/search.css
View File

@ -88,7 +88,7 @@
} }
} }
#search_arrows:focus { #searchbox-input-container:focus {
box-shadow: inset 0 0 0 2px hsl(204deg 20% 74%); box-shadow: inset 0 0 0 2px hsl(204deg 20% 74%);
} }
@ -132,7 +132,7 @@
left: 0; left: 0;
} }
#search_arrows { #searchbox-input-container {
font-size: 90%; font-size: 90%;
letter-spacing: normal; letter-spacing: normal;
padding-left: 0; padding-left: 0;

2
web/templates/navbar.hbs
View File

@ -17,7 +17,7 @@
</div> </div>
<div id="searchbox"> <div id="searchbox">
<form id="searchbox_form" class="navbar-search"> <form id="searchbox_form" class="navbar-search">
<div id="search_arrows" class="input-append"> <div id="searchbox-input-container" class="input-append">
<span class="search_icon"><i class="zulip-icon zulip-icon-search tippy-zulip-delayed-tooltip" data-tooltip-template-id="search-query-tooltip-template"></i></span> <span class="search_icon"><i class="zulip-icon zulip-icon-search tippy-zulip-delayed-tooltip" data-tooltip-template-id="search-query-tooltip-template"></i></span>
<input class="search-query input-block-level home-page-input" id="search_query" type="text" placeholder="{{t 'Search' }}" <input class="search-query input-block-level home-page-input" id="search_query" type="text" placeholder="{{t 'Search' }}"
autocomplete="off"/> autocomplete="off"/>