Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

timerender: Remove "Active just now" user status. 

Currently, we only show the "Active just now" status once a user has gone
offline within the last 2 minutes. This ends up never showing up the
threshhold which the client marks an user as user is longer than 3 minutes.
Thus deemingthe user status as useless. After a discussion on CZO, it was
decided that we should remove this status altogether as the phrasing doesn't
make sense as well.
This commit is contained in:
Joelute 2023-04-12 20:27:02 -04:00 committed by Tim Abbott
parent 1e98a659c1
commit a96cfb58bd
2 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
web/src/timerender.ts
View File

@ -240,9 +240,6 @@ export function last_seen_status_from_date(
current_date = new Date(), current_date = new Date(),
): string { ): string {
const minutes = differenceInMinutes(current_date, last_active_date); const minutes = differenceInMinutes(current_date, last_active_date);
if (minutes <= 2) {
return $t({defaultMessage: "Active just now"});
}
if (minutes < 60) { if (minutes < 60) {
return $t({defaultMessage: "Active {minutes} minutes ago"}, {minutes}); return $t({defaultMessage: "Active {minutes} minutes ago"}, {minutes});
} }

6
web/tests/timerender.test.js
View File

@ -473,12 +473,6 @@ run_test("last_seen_status_from_date", () => {
assert.equal(actual_status, expected_status); assert.equal(actual_status, expected_status);
} }
assert_same({seconds: -20}, $t({defaultMessage: "Active just now"}));
assert_same({minutes: -1}, $t({defaultMessage: "Active just now"}));
assert_same({minutes: -2}, $t({defaultMessage: "Active just now"}));
assert_same({minutes: -30}, $t({defaultMessage: "Active 30 minutes ago"})); assert_same({minutes: -30}, $t({defaultMessage: "Active 30 minutes ago"}));
assert_same({hours: -1}, $t({defaultMessage: "Active an hour ago"})); assert_same({hours: -1}, $t({defaultMessage: "Active an hour ago"}));