performance: Cache stream lookups in MentionBackend.

This is useful when you subscribe a bunch of folks
to a stream and need to send them all PMs telling
them about the new subscription.

zerver/lib/mention.py

@@ -41,6 +41,7 @@ class MentionBackend:
     def __init__(self, realm_id: int) -> None:
         self.realm_id = realm_id
         self.user_cache: Dict[Tuple[int, str], FullNameInfo] = {}
+        self.stream_cache: Dict[str, int] = {}
 
     def get_full_name_info_list(self, user_filters: List[UserFilter]) -> List[FullNameInfo]:
         result: List[FullNameInfo] = []
@@ -97,7 +98,17 @@ class MentionBackend:
         if not stream_names:
             return {}
 
-        q_list = {Q(name=name) for name in stream_names}
+        result: Dict[str, int] = {}
+        unseen_stream_names: List[str] = []
+
+        for stream_name in stream_names:
+            if stream_name in self.stream_cache:
+                result[stream_name] = self.stream_cache[stream_name]
+            else:
+                unseen_stream_names.append(stream_name)
+
+        if unseen_stream_names:
+            q_list = {Q(name=name) for name in unseen_stream_names}
 
             rows = (
                 get_linkable_streams(
@@ -112,8 +123,11 @@ class MentionBackend:
                 )
             )
 
-        dct = {row["name"]: row["id"] for row in rows}
-        return dct
+            for row in rows:
+                self.stream_cache[row["name"]] = row["id"]
+                result[row["name"]] = row["id"]
+
+        return result
 
 
 def user_mention_matches_wildcard(mention: str) -> bool:

zerver/tests/test_subs.py

@@ -4971,7 +4971,7 @@ class GetSubscribersTest(ZulipTestCase):
                 streams,
                 dict(principals=orjson.dumps(users_to_subscribe).decode()),
             )
-        self.assert_length(queries, 48)
+        self.assert_length(queries, 46)
 
         msg = f"""
             @**King Hamlet|{hamlet.id}** subscribed you to the following streams: