mirror of https://github.com/zulip/zulip.git
settings: Add tooltip to clarify invalid Jitsi URL.
This commit adds a tooltip in organization settings, when the save button is disabled due to invalid Jitsi URL. Fixes #27511. Co-authored-by: Angelica Ferlin <angelica.ferlin@gmail.com> Co-authored-by: Peterson Linn <linn@pajp.net> Co-authored-by: Kislay Verma <kislayuv27@gmail.com>
This commit is contained in:
parent
5f35384c80
commit
a90f7cce6f
|
@ -27,6 +27,7 @@ IGNORED_PHRASES = [
|
||||||
r"Inbox",
|
r"Inbox",
|
||||||
r"IP",
|
r"IP",
|
||||||
r"JSON",
|
r"JSON",
|
||||||
|
r"Jitsi",
|
||||||
r"Kerberos",
|
r"Kerberos",
|
||||||
r"LinkedIn",
|
r"LinkedIn",
|
||||||
r"LDAP",
|
r"LDAP",
|
||||||
|
|
|
@ -1,6 +1,6 @@
|
||||||
import $ from "jquery";
|
import $ from "jquery";
|
||||||
import assert from "minimalistic-assert";
|
import assert from "minimalistic-assert";
|
||||||
import type {Props} from "tippy.js";
|
import type {PopperElement, Props} from "tippy.js";
|
||||||
import tippy from "tippy.js";
|
import tippy from "tippy.js";
|
||||||
|
|
||||||
import render_compose_banner from "../templates/compose_banner/compose_banner.hbs";
|
import render_compose_banner from "../templates/compose_banner/compose_banner.hbs";
|
||||||
|
@ -916,6 +916,23 @@ function enable_or_disable_save_button($subsection_elem: JQuery): void {
|
||||||
disable_save_btn = should_disable_save_button_for_time_limit_settings(time_limit_settings);
|
disable_save_btn = should_disable_save_button_for_time_limit_settings(time_limit_settings);
|
||||||
} else if ($subsection_elem.attr("id") === "org-other-settings") {
|
} else if ($subsection_elem.attr("id") === "org-other-settings") {
|
||||||
disable_save_btn = should_disable_save_button_for_jitsi_server_url_setting();
|
disable_save_btn = should_disable_save_button_for_jitsi_server_url_setting();
|
||||||
|
const $button_wrapper = $subsection_elem.find<PopperElement>(".subsection-changes-save");
|
||||||
|
const tippy_instance = $button_wrapper[0]._tippy;
|
||||||
|
if (disable_save_btn) {
|
||||||
|
// avoid duplication of tippy
|
||||||
|
if (!tippy_instance) {
|
||||||
|
const opts: Partial<Props> = {placement: "top"};
|
||||||
|
initialize_disable_btn_hint_popover(
|
||||||
|
$button_wrapper,
|
||||||
|
$t({defaultMessage: "Cannot save invalid Jitsi server URL."}),
|
||||||
|
opts,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
if (tippy_instance) {
|
||||||
|
tippy_instance.destroy();
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
$subsection_elem.find(".subsection-changes-save button").prop("disabled", disable_save_btn);
|
$subsection_elem.find(".subsection-changes-save button").prop("disabled", disable_save_btn);
|
||||||
|
|
Loading…
Reference in New Issue