Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor: Inline batched_updater into send_read. 

The only remaining caller for batched_updater was send_read,
so this commit inlines it and removes code paths that are
no longer relevant.
This commit is contained in:
Steve Howell 2017-12-15 18:04:37 -05:00 committed by showell
parent 7a362861d0
commit a8cd7655d3
1 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
static/js/message_flags.js
View File

@ -13,7 +13,7 @@ function send_flag_update(message, flag, op) {
});
}
function batched_updater(flag, op, immediate) {
exports.send_read = (function () {
var queue = [];
var on_success;
var start;
@ -39,17 +39,13 @@ function batched_updater(flag, op, immediate) {
url: '/json/messages/flags',
idempotent: true,
data: {messages: JSON.stringify(real_msg_ids),
op: op,
flag: flag},
op: 'add',
flag: 'read'},
success: on_success,
});
}
if (immediate) {
start = server_request;
} else {
start = _.debounce(server_request, 1000);
}
start = _.debounce(server_request, 1000);
on_success = function on_success(data) {
if (data === undefined || data.messages === undefined) {
@ -69,19 +65,13 @@ function batched_updater(flag, op, immediate) {
if (message.flags === undefined) {
message.flags = [];
}
if (op === 'add') {
message.flags.push(flag);
} else {
message.flags = _.without(message.flags, flag);
}
message.flags.push('read');
queue.push(message);
start();
}
return add;
}
exports.send_read = batched_updater('read', 'add');
}());
exports.save_collapsed = function (message) {
send_flag_update(message, 'collapsed', true);