Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

lightbox: Convert asset_map from object to Map. 

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg 2020-02-12 01:56:06 -08:00 committed by Tim Abbott
parent f8bf0f4c49
commit a889a830dc
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
static/js/lightbox.js
View File

@ -1,9 +1,7 @@
let is_open = false;
// the asset map is a map of all retrieved images and YouTube videos that are
// memoized instead of being looked up multiple times.
const asset_map = {
};
const asset_map = new Map();
function render_lightbox_list_images(preview_source) {
if (!is_open) {
@ -99,14 +97,12 @@ exports.open = function (image, options) {
// check if image is descendent of #preview_content
const is_compose_preview_image = $image.closest("#preview_content").length === 1;
let payload;
// if the asset_map already contains the metadata required to display the
// asset, just recall that metadata.
const $image_source = $image.attr("data-src-fullsize") || $image.attr("src");
if (asset_map[$image_source]) {
payload = asset_map[$image_source];
// otherwise retrieve the metadata from the DOM and store into the asset_map.
} else {
let payload = asset_map.get($image_source);
if (payload === undefined) {
// otherwise retrieve the metadata from the DOM and store into the asset_map.
const $parent = $image.parent();
let $type;
let $source;
@ -151,7 +147,7 @@ exports.open = function (image, options) {
url: $url,
};
asset_map[$source] = payload;
asset_map.set($source, payload);
}
if (payload.type.match("-video")) {