Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

message scrolling: Extract _new_messages_height().

This commit is contained in:
Steve Howell 2019-01-05 15:25:21 +00:00 committed by Tim Abbott
parent 0c6175f27e
commit a7c92a2590
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
static/js/message_list_view.js
View File

@ -742,15 +742,12 @@ MessageListView.prototype = {
} }
if (list === current_msg_list && messages_are_new) { if (list === current_msg_list && messages_are_new) {
self._maybe_autoscroll(new_dom_elements); var new_messages_height = self._new_messages_height(new_dom_elements);
self._maybe_autoscroll(new_messages_height);
} }
}, },
_new_messages_height: function (rendered_elems) {
_maybe_autoscroll: function (rendered_elems) {
// If we are near the bottom of our feed (the bottom is visible) and can
// scroll up without moving the pointer out of the viewport, do so, by
// up to the amount taken up by the new message.
var new_messages_height = 0; var new_messages_height = 0;
var id_of_last_message_sent_by_us = -1; var id_of_last_message_sent_by_us = -1;
@ -773,6 +770,14 @@ MessageListView.prototype = {
} }
}, this); }, this);
return new_messages_height;
},
_maybe_autoscroll: function (new_messages_height) {
// If we are near the bottom of our feed (the bottom is visible) and can
// scroll up without moving the pointer out of the viewport, do so, by
// up to the amount taken up by the new message.
var selected_row = this.selected_row(); var selected_row = this.selected_row();
var last_visible = rows.last_visible(); var last_visible = rows.last_visible();