Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Use comprehensions more consistently in bulk create 

(imported from commit f6b67b9ce74b379004e5fde6c99368c077a77f7b)
This commit is contained in:
Keegan McAllister 2012-10-31 11:28:27 -04:00
parent 51a96484f9
commit a70d82b8fc
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
zephyr/models.py
View File

@ -94,9 +94,7 @@ class Realm(models.Model):
return self.__repr__()
def bulk_create_realms(realm_list):
existing_realms = set()
for realm in Realm.objects.select_related().all():
existing_realms.add(realm.domain)
existing_realms = set(r.domain for r in Realm.objects.select_related().all())
realms_to_create = []
for domain in realm_list:
@ -273,9 +271,8 @@ def create_stream_if_needed(realm, stream_name):
return stream
def bulk_create_streams(realms, stream_list):
existing_streams = set()
for stream in Stream.objects.select_related().all():
existing_streams.add((stream.realm.domain, stream.name.lower()))
existing_streams = set((stream.realm.domain, stream.name.lower())
for stream in Stream.objects.select_related().all())
streams_to_create = []
for (domain, name) in stream_list:
if (domain, name.lower()) not in existing_streams:
@ -356,9 +353,7 @@ def get_client(name):
return client
def bulk_create_clients(client_list):
existing_clients = set()
for client in Client.objects.select_related().all():
existing_clients.add(client.name)
existing_clients = set(client.name for client in Client.objects.select_related().all())
clients_to_create = []
for name in client_list: