Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

delete_topic: Add retry logic in the webapp.

This commit is contained in:
Mateusz Mandera 2022-09-22 22:26:20 +02:00 committed by Tim Abbott
parent 940830055b
commit a359362845
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
static/js/message_edit.js
View File

@ -1133,12 +1133,31 @@ export function delete_message(msg_id) {
});
}
export function delete_topic(stream_id, topic_name) {
export function delete_topic(stream_id, topic_name, failures = 0) {
channel.post({
url: "/json/streams/" + stream_id + "/delete_topic",
data: {
topic_name,
},
success() {},
error(xhr) {
if (failures >= 9) {
// Don't keep retrying indefinitely to avoid DoSing the server.
return;
}
if (xhr.status === 502) {
/* When trying to delete a very large topic, it's
possible for the request to the server to
time out after making some progress. Retry the
request, so that the user can just do nothing and
watch the topic slowly be deleted.
TODO: Show a nice loading indicator experience.
*/
failures += 1;
delete_topic(stream_id, topic_name, failures);
}
},
});
}