Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

message_edit: len(changed_messages) is always > 0. 

It is only ever added to, and starts as a one-element list.

(cherry picked from commit db3bcb8889)
This commit is contained in:
Alex Vandiver 2023-09-25 20:56:20 +00:00 committed by Tim Abbott
parent eeedc34e58
commit a25ee8aad0
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/actions/message_edit.py
View File

@ -977,7 +977,7 @@ def do_update_message(
send_event(user_profile.realm, event, users_to_be_notified) send_event(user_profile.realm, event, users_to_be_notified)
resolved_topic_message_id = None resolved_topic_message_id = None
if topic_name is not None and content is None and len(changed_messages) > 0: if topic_name is not None and content is None:
# When stream is changed and topic is marked as resolved or unresolved # When stream is changed and topic is marked as resolved or unresolved
# in the same API request, resolved or unresolved notification should # in the same API request, resolved or unresolved notification should
# be sent to "new_stream". # be sent to "new_stream".
@ -995,11 +995,7 @@ def do_update_message(
changed_messages=changed_messages, changed_messages=changed_messages,
) )
if ( if (new_stream is not None or topic_name is not None) and stream_being_edited is not None:
len(changed_messages) > 0
and (new_stream is not None or topic_name is not None)
and stream_being_edited is not None
):
# Notify users that the topic was moved. # Notify users that the topic was moved.
changed_messages_count = len(changed_messages) changed_messages_count = len(changed_messages)