From a2315422e7855fa67970238c437ef4fadc028f30 Mon Sep 17 00:00:00 2001
From: Sahil Batra <sahil@zulip.com>
Date: Wed, 1 Feb 2023 21:36:21 +0530
Subject: [PATCH] settings: Override bottom margin for inputs.

We override the bottom margin added by bootstrap for
url type custom profile input in user profile page
and all the inputs in edit-user form. Previously, this
was handled by form-horizontal class which was removed
in #24057.

For most of the other text-type inputs, it is overridden
in app_components.css and for checkbox-type inputs, it is
overridden by other bootstrap CSS itself. But that only
handles text-type and checkbox-type inputs inside
".new-style" element and not url type inputs.
Some other inputs already have specific CSS to override the
bootstrap CSS.

For the same reason, there is no need to override bottom
margin for inputs in organization profile as there is no
url type inputs in that page and this commit removes the
CSS for it.
---
 static/styles/settings.css | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/static/styles/settings.css b/static/styles/settings.css
index 404ffba9b8..df84eaf10a 100644
--- a/static/styles/settings.css
+++ b/static/styles/settings.css
@@ -451,11 +451,6 @@ input[type="checkbox"] {
     margin-top: 10px;
 }
 
-#organization-profile input {
-    /* Override undesired Bootstrap default. */
-    margin-bottom: 0;
-}
-
 #id_org_profile_preview {
     margin-bottom: 20px;
     display: inline-flex;
@@ -1426,6 +1421,12 @@ $option_title_width: 180px;
         padding-left: 2px;
         vertical-align: middle;
     }
+
+    input,
+    input[type="url"] {
+        /* Override undesired Bootstrap default. */
+        margin-bottom: 0;
+    }
 }
 
 /* These have enough space for all the options in German. */