Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

tests: Remove redundant test_notify_settings test. 

We already test all the notification settinsg in
test_toggling_boolean_display_settings (which is
now renamed to test_toggling_boolean_user_settings)
as all settings are now moved to property_types and
we are merging other parts also to consider all the
settings under one category.
This commit is contained in:
Sahil Batra 2021-09-08 22:02:53 +05:30 committed by Tim Abbott
parent d6d1a139d0
commit a229231dd4
1 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
zerver/tests/test_settings.py
View File

@ -133,16 +133,6 @@ class ChangeSettingsTest(ZulipTestCase):
json_result = self.client_patch("/json/settings", dict(email="hamlet@mailnator.com")) json_result = self.client_patch("/json/settings", dict(email="hamlet@mailnator.com"))
self.assert_json_error(json_result, "Please use your real email address.") self.assert_json_error(json_result, "Please use your real email address.")
# This is basically a don't-explode test.
def test_notify_settings(self) -> None:
for notification_setting in UserProfile.notification_setting_types.keys():
# `notification_sound` is a string not a boolean, so this test
# doesn't work for it.
#
# TODO: Make this work more like do_test_realm_update_api
if UserProfile.notification_setting_types[notification_setting] is bool:
self.check_for_toggle_param_patch("/json/settings", notification_setting)
def test_change_email_batching_period(self) -> None: def test_change_email_batching_period(self) -> None:
hamlet = self.example_user("hamlet") hamlet = self.example_user("hamlet")
self.login_user(hamlet) self.login_user(hamlet)
@ -167,13 +157,13 @@ class ChangeSettingsTest(ZulipTestCase):
hamlet = self.example_user("hamlet") hamlet = self.example_user("hamlet")
self.assertEqual(hamlet.email_notifications_batching_period_seconds, 300) self.assertEqual(hamlet.email_notifications_batching_period_seconds, 300)
def test_toggling_boolean_user_display_settings(self) -> None: def test_toggling_boolean_user_settings(self) -> None:
"""Test updating each boolean setting in UserProfile property_types""" """Test updating each boolean setting in UserProfile property_types"""
boolean_settings = ( boolean_settings = (
s for s in UserProfile.property_types if UserProfile.property_types[s] is bool s for s in UserProfile.property_types if UserProfile.property_types[s] is bool
) )
for display_setting in boolean_settings: for user_setting in boolean_settings:
self.check_for_toggle_param_patch("/json/settings", display_setting) self.check_for_toggle_param_patch("/json/settings", user_setting)
def test_wrong_old_password(self) -> None: def test_wrong_old_password(self) -> None:
self.login("hamlet") self.login("hamlet")