Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings_org: Fix exception processing stream type events. 

The previous check looked at whether the settings overlay as a whole
was open, not whether the specific panel we're going to update was
rendered.

The other code paths calling from server_events_dispatch into this
module already correctly check meta.loaded.
This commit is contained in:
Tim Abbott 2022-11-02 11:39:58 -07:00
parent 3a9730b7c6
commit a1aba2869b
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
frontend_tests/node_tests/settings_org.js
View File

@ -14,7 +14,6 @@ const noop = () => {};
const realm_icon = mock_esm("../../static/js/realm_icon");
const channel = mock_esm("../../static/js/channel");
const overlays = mock_esm("../../static/js/overlays");
mock_esm("../../static/js/csrf", {csrf_token: "token-stub"});
mock_esm("../../static/js/list_widget", {
@ -309,8 +308,6 @@ function test_extract_property_name() {
}
function test_sync_realm_settings() {
overlays.settings_open = () => true;
{
/* Test invalid settings property sync */
const $property_elem = $("#id_realm_invalid_settings_property");

3
static/js/settings_org.js
View File

@ -11,7 +11,6 @@ import {csrf_token} from "./csrf";
import {DropdownListWidget} from "./dropdown_list_widget";
import {$t, $t_html, get_language_name} from "./i18n";
import * as loading from "./loading";
import * as overlays from "./overlays";
import {page_params} from "./page_params";
import * as realm_icon from "./realm_icon";
import * as realm_logo from "./realm_logo";
@ -590,7 +589,7 @@ function discard_property_element_changes(elem, for_realm_default_settings) {
}
export function sync_realm_settings(property) {
if (!overlays.settings_open()) {
if (!meta.loaded) {
return;
}