From a1a5a1643f8ffd76b752ef70ac7add17c9637d53 Mon Sep 17 00:00:00 2001
From: Sahil Batra <sahil@zulip.com>
Date: Tue, 9 Nov 2021 23:29:22 +0530
Subject: [PATCH] settings: Remove unused show_email parameter.

We show "Email" column heading always in users list and
subscriber list irrespective of the email-address visibility
setting after 46660e5, so we do need to pass show_email
parameter to render_admin_tab and render_stream_settings.
---
 static/js/admin.js                                   | 1 -
 static/js/stream_edit.js                             | 1 -
 static/templates/stream_settings/stream_settings.hbs | 2 +-
 3 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/static/js/admin.js b/static/js/admin.js
index ebfd58b7f7..8045918f3f 100644
--- a/static/js/admin.js
+++ b/static/js/admin.js
@@ -126,7 +126,6 @@ export function build_page() {
         settings_send_digest_emails: page_params.settings_send_digest_emails,
         realm_digest_emails_enabled: page_params.realm_digest_emails_enabled,
         realm_digest_weekday: page_params.realm_digest_weekday,
-        show_email: settings_data.show_email(),
         development: page_params.development_environment,
         zulip_plan_is_not_limited: page_params.zulip_plan_is_not_limited,
         upgrade_text_for_wide_organization_logo:
diff --git a/static/js/stream_edit.js b/static/js/stream_edit.js
index 9e53a6ece9..284cdcc2db 100644
--- a/static/js/stream_edit.js
+++ b/static/js/stream_edit.js
@@ -535,7 +535,6 @@ export function show_settings_for(node) {
         other_settings,
         stream_post_policy_values: stream_data.stream_post_policy_values,
         message_retention_text: get_retention_policy_text_for_subscription_type(sub),
-        show_email: settings_data.show_email(),
     });
     ui.get_content_element($("#stream_settings")).html(html);
 
diff --git a/static/templates/stream_settings/stream_settings.hbs b/static/templates/stream_settings/stream_settings.hbs
index 0731a33df3..c2eab230bc 100644
--- a/static/templates/stream_settings/stream_settings.hbs
+++ b/static/templates/stream_settings/stream_settings.hbs
@@ -122,7 +122,7 @@
         <div class="subscriber_settings stream_section">
             {{#with sub}}
             <div class="subscription-members-setting">
-                {{> stream_members show_email=../show_email}}
+                {{> stream_members}}
             </div>
             {{/with}}
         </div>