Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Rename "operators" to "filters" in "Search operators" reference. 

Changes all the uses of the word "operators" to "filters" in the
in-app "Search operators" reference to align with the updated help
center documentation.

Fixes #23767.
This commit is contained in:
David Rosa 2022-12-08 21:13:09 -06:00 committed by Tim Abbott
parent 3b0e311f83
commit a153e9232e
5 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
frontend_tests/node_tests/components.js
View File

@ -44,7 +44,7 @@ function make_tab(i) {
[ [
"translated: Keyboard shortcuts", "translated: Keyboard shortcuts",
"translated: Message formatting", "translated: Message formatting",
"translated: Search operators", "translated: Search filters",
][i], ][i],
); );
}; };
@ -189,7 +189,7 @@ run_test("basics", () => {
values: [ values: [
{label: $t({defaultMessage: "Keyboard shortcuts"}), key: "keyboard-shortcuts"}, {label: $t({defaultMessage: "Keyboard shortcuts"}), key: "keyboard-shortcuts"},
{label: $t({defaultMessage: "Message formatting"}), key: "message-formatting"}, {label: $t({defaultMessage: "Message formatting"}), key: "message-formatting"},
{label: $t({defaultMessage: "Search operators"}), key: "search-operators"}, {label: $t({defaultMessage: "Search filters"}), key: "search-operators"},
], ],
html_class: "stream_sorter_toggle", html_class: "stream_sorter_toggle",
callback(name, key) { callback(name, key) {
@ -238,13 +238,13 @@ run_test("basics", () => {
assert.equal(env.tabs[0].class, "first"); assert.equal(env.tabs[0].class, "first");
assert.equal(env.tabs[1].class, "middle"); assert.equal(env.tabs[1].class, "middle");
assert.equal(env.tabs[2].class, "last selected"); assert.equal(env.tabs[2].class, "last selected");
assert.deepEqual(callback_args, ["translated: Search operators", "search-operators"]); assert.deepEqual(callback_args, ["translated: Search filters", "search-operators"]);
assert.equal(widget.value(), "translated: Search operators"); assert.equal(widget.value(), "translated: Search filters");
assert.equal(widget.value(), callback_value); assert.equal(widget.value(), callback_value);
// try to crash the key handler // try to crash the key handler
env.keydown_f.call(env.tabs[env.focused_tab], RIGHT_KEY); env.keydown_f.call(env.tabs[env.focused_tab], RIGHT_KEY);
assert.equal(widget.value(), "translated: Search operators"); assert.equal(widget.value(), "translated: Search filters");
callback_args = undefined; callback_args = undefined;
@ -264,7 +264,7 @@ run_test("basics", () => {
widget.disable_tab("message-formatting"); widget.disable_tab("message-formatting");
env.keydown_f.call(env.tabs[env.focused_tab], RIGHT_KEY); env.keydown_f.call(env.tabs[env.focused_tab], RIGHT_KEY);
assert.equal(widget.value(), "translated: Search operators"); assert.equal(widget.value(), "translated: Search filters");
callback_args = undefined; callback_args = undefined;

2
static/js/gear_menu.js
View File

@ -26,7 +26,7 @@ link: Usage statistics
link: Help center link: Help center
info: Keyboard shortcuts info: Keyboard shortcuts
info: Message formatting info: Message formatting
info: Search operators info: Search filters
hash: About Zulip hash: About Zulip
--- ---
link: Desktop & mobile apps link: Desktop & mobile apps

2
static/js/info_overlay.js
View File

@ -214,7 +214,7 @@ export function set_up_toggler() {
values: [ values: [
{label: $t({defaultMessage: "Keyboard shortcuts"}), key: "keyboard-shortcuts"}, {label: $t({defaultMessage: "Keyboard shortcuts"}), key: "keyboard-shortcuts"},
{label: $t({defaultMessage: "Message formatting"}), key: "message-formatting"}, {label: $t({defaultMessage: "Message formatting"}), key: "message-formatting"},
{label: $t({defaultMessage: "Search operators"}), key: "search-operators"}, {label: $t({defaultMessage: "Search filters"}), key: "search-operators"},
], ],
callback(name, key) { callback(name, key) {
$(".overlay-modal").hide(); $(".overlay-modal").hide();

2
static/templates/gear_menu.hbs
View File

@ -100,7 +100,7 @@
</li> </li>
<li role="presentation"> <li role="presentation">
<a tabindex="0" role="menuitem" data-overlay-trigger="search-operators"> <a tabindex="0" role="menuitem" data-overlay-trigger="search-operators">
<i class="fa fa-search" aria-hidden="true"></i> {{t 'Search operators' }} <i class="fa fa-search" aria-hidden="true"></i> {{t 'Search filters' }}
</a> </a>
</li> </li>
<li class="divider only-visible-for-spectators" role="presentation"></li> <li class="divider only-visible-for-spectators" role="presentation"></li>

8
static/templates/search_operators.hbs
View File

@ -1,10 +1,10 @@
<div class="overlay-modal hide" id="search-operators" tabindex="-1" role="dialog" aria-label="{{t 'Search operators' }}"> <div class="overlay-modal hide" id="search-operators" tabindex="-1" role="dialog" aria-label="{{t 'Search filters' }}">
<div class="modal-body" data-simplebar data-simplebar-auto-hide="false"> <div class="modal-body" data-simplebar data-simplebar-auto-hide="false">
<div id="operators-instructions"> <div id="operators-instructions">
<table class="table table-striped table-condensed table-rounded table-bordered help-table"> <table class="table table-striped table-condensed table-rounded table-bordered help-table">
<thead> <thead>
<tr> <tr>
<th>{{t "Operator" }}</th> <th>{{t "Filter" }}</th>
<th>{{t "Effect" }}</th> <th>{{t "Effect" }}</th>
</tr> </tr>
</thead> </thead>
@ -158,9 +158,9 @@
</tr> </tr>
</tbody> </tbody>
</table> </table>
<p>{{t "You can combine search operators as needed." }}</p> <p>{{t "You can combine search filters as needed." }}</p>
<hr /> <hr />
<a href="help/search-for-messages#search-operators" target="_blank" rel="noopener noreferrer">{{t "Detailed search operators documentation" }}</a> <a href="help/search-for-messages#search-filters" target="_blank" rel="noopener noreferrer">{{t "Detailed search filters documentation" }}</a>
</div> </div>
</div> </div>
</div> </div>