Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings: Remove form-horizontal class from notification settings. 

This commit removes form-horizontal class from time-limit-setting
div in notfication_settings.hbs. We can safely remove this class
since display and vertical-align properties are applied for select
and input elements by other bootstrap CSS, the margin-bottom
property for custom input is applied by existing CSS in
app_components.css and this commit adds margin-bottom property for
select elements.

The CSS added in this commit will probably be removed once we
remove bootstrap CSS rules for select elements completely.
This commit is contained in:
Sahil Batra 2023-01-10 15:52:51 +05:30 committed by Tim Abbott
parent aa7329e18b
commit a144166e12
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
static/styles/settings.css
View File

@ -213,6 +213,11 @@ h3,
text-transform: capitalize;
}
select.setting_email_notifications_batching_period_seconds {
/* Override undesired Bootstrap default. */
margin-bottom: 0;
}
.table {
tbody {
border-bottom: 1px solid hsl(0, 0%, 87%);

2
static/templates/settings/notification_settings.hbs
View File

@ -124,7 +124,7 @@
{{> settings_save_discard_widget section_name="email-message-settings" show_only_indicator=(not for_realm_settings) }}
</div>
<div class="input-group form-horizontal time-limit-setting">
<div class="input-group time-limit-setting">
<label for="email_notifications_batching_period">
{{t "Delay before sending message notification emails" }}