From a0f3f3dfa02d9b0d0e481e11b47b18dbc20947f2 Mon Sep 17 00:00:00 2001
From: Tim Abbott <tabbott@zulipchat.com>
Date: Fri, 30 Dec 2016 12:43:19 -0800
Subject: [PATCH] lint: Forbid script tags in handlebars templates.

---
 tools/lint-all | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/lint-all b/tools/lint-all
index cd6aa34c3d..90cfc4a053 100755
--- a/tools/lint-all
+++ b/tools/lint-all
@@ -388,7 +388,10 @@ def build_custom_checkers(by_lang):
          ]),
          'description': "`title` value should be translatable."},
         ] # type: RuleList
-    handlebars_rules = html_rules
+    handlebars_rules = html_rules + [
+        {'pattern': "[<]script",
+         'description': "Do not use inline <script> tags here; put JavaScript in static/js instead."},
+    ]
     json_rules = [] # type: RuleList # fix newlines at ends of files
     # It is okay that json_rules is empty, because the empty list
     # ensures we'll still check JSON files for whitespace.