From a092e96bffee0caee40cbaa4a4eda6a89b135592 Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Mon, 29 Mar 2021 09:39:20 -0700 Subject: [PATCH] message_edit: Rename start_inline_topic_edit. This function should be named similarly to the well-named end_inline_topic_edit; previously the main hint that this was the inline code path was just that the recipient_row was the parameter. --- static/js/click_handlers.js | 2 +- static/js/message_edit.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/static/js/click_handlers.js b/static/js/click_handlers.js index 6ea25e3bf3..5164426d95 100644 --- a/static/js/click_handlers.js +++ b/static/js/click_handlers.js @@ -311,7 +311,7 @@ export function initialize() { }); $("body").on("click", ".always_visible_topic_edit,.on_hover_topic_edit", function (e) { const recipient_row = $(this).closest(".recipient_row"); - message_edit.start_topic_edit(recipient_row); + message_edit.start_inline_topic_edit(recipient_row); e.stopPropagation(); popovers.hide_all(); }); diff --git a/static/js/message_edit.js b/static/js/message_edit.js index c105fad334..7611b10dd4 100644 --- a/static/js/message_edit.js +++ b/static/js/message_edit.js @@ -556,7 +556,7 @@ export function start(row, edit_box_open_callback) { }); } -export function start_topic_edit(recipient_row) { +export function start_inline_topic_edit(recipient_row) { const form = $(render_topic_edit_form()); current_msg_list.show_edit_topic_on_recipient_row(recipient_row, form); form.on("keydown", handle_inline_topic_edit_keydown);