Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

actions: Pass realm_playgrounds as argument to notify_realm_playgrounds. 

This commit modifies the notify_realm_playgrounds function to accept
realm_playgrounds as argument from the caller instead of computing it
in the function to avoid duplicate queries since the realm playgrounds
list will be required in its caller functions as well in further commits.
This commit is contained in:
Sahil Batra 2022-03-15 13:07:34 +05:30 committed by Tim Abbott
parent f77204be14
commit 9fd9c5f1d2
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
zerver/lib/actions.py
View File

@ -8097,8 +8097,10 @@ def do_remove_realm_domain(
transaction.on_commit(lambda: send_event(realm, event, active_user_ids(realm.id))) transaction.on_commit(lambda: send_event(realm, event, active_user_ids(realm.id)))
def notify_realm_playgrounds(realm: Realm) -> None: def notify_realm_playgrounds(
event = dict(type="realm_playgrounds", realm_playgrounds=get_realm_playgrounds(realm)) realm: Realm, realm_playgrounds: List[Dict[str, Union[int, str]]]
) -> None:
event = dict(type="realm_playgrounds", realm_playgrounds=realm_playgrounds)
send_event(realm, event, active_user_ids(realm.id)) send_event(realm, event, active_user_ids(realm.id))
@ -8109,13 +8111,16 @@ def do_add_realm_playground(realm: Realm, **kwargs: Any) -> int:
# before calling this function. # before calling this function.
realm_playground.full_clean() realm_playground.full_clean()
realm_playground.save() realm_playground.save()
notify_realm_playgrounds(realm) realm_playgrounds = get_realm_playgrounds(realm)
notify_realm_playgrounds(realm, realm_playgrounds)
return realm_playground.id return realm_playground.id
def do_remove_realm_playground(realm: Realm, realm_playground: RealmPlayground) -> None: def do_remove_realm_playground(realm: Realm, realm_playground: RealmPlayground) -> None:
realm_playground.delete() realm_playground.delete()
notify_realm_playgrounds(realm) realm_playgrounds = get_realm_playgrounds(realm)
notify_realm_playgrounds(realm, realm_playgrounds)
def get_occupied_streams(realm: Realm) -> QuerySet: def get_occupied_streams(realm: Realm) -> QuerySet: