From 9fb6b4d0164bcdd5c3e0157e2676dd974b7d5cf5 Mon Sep 17 00:00:00 2001
From: Karl Stolley <karl@zulip.com>
Date: Wed, 3 Jul 2024 16:13:18 -0500
Subject: [PATCH] left_sidebar: More carefully generate auto rows for expanded
 nav.

---
 web/styles/left_sidebar.css | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/web/styles/left_sidebar.css b/web/styles/left_sidebar.css
index 765bbf505b..9443ec0e1d 100644
--- a/web/styles/left_sidebar.css
+++ b/web/styles/left_sidebar.css
@@ -590,7 +590,8 @@ li.active-sub-filter {
     /* Explicitly ensure parity with the line-height
        for the sake of low-resolution screens, whose
        font-rendering and rounding may cause icons
-       to appear out of alignment. */
+       to appear out of alignment. This grid feature should
+       only apply in the expanded-navigation view. */
     grid-auto-rows: var(--line-height-sidebar-row);
 
     .left-sidebar-navigation-label-container {
@@ -791,6 +792,10 @@ li.top_left_scheduled_messages {
        filter rows as needed, based on the narrow. */
     &.showing-condensed-navigation {
         + #left-sidebar-navigation-list {
+            /* In the condensed state, we don't want to generate
+               auto rows, or there will be a footprint where the
+               expanded nav sits. */
+            grid-auto-rows: unset;
             /* When the navigation area is condensed, hide all
                the rows in the full navigation list... */
             & .top_left_row {
@@ -800,6 +805,9 @@ li.top_left_scheduled_messages {
                that row should still be shown. */
             & .top_left_row.active-filter {
                 display: grid;
+                /* In the absence of auto rows in the condensed state,
+                   we set an explicit height on the active filter. */
+                height: var(--line-height-sidebar-row);
             }
         }
     }