Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

search tests: Refactor search according to search_legacy. 

Now node_tests/search.js and node_tests/search_legacy.js have
almost identical test besides the search pills related data
processing work.
This is possible since we no longer depend on the values stored
in the input pills and can narrow or search for term based on
the `#search_query` box value.
This was done in commit 02ab48a61e.
This commit is contained in:
Ryan Rehman 2020-05-31 20:17:55 +05:30 committed by Tim Abbott
parent aeb4419d52
commit 9faf238e8e
2 changed files with 30 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
frontend_tests/node_tests/search.js
View File

@ -40,6 +40,13 @@ run_test('update_button_visibility', () => {
const search_query = $('#search_query');
const search_button = $('.search_button');
search_query.is = return_false;
search_query.val('');
narrow_state.active = return_false;
search_button.prop('disabled', true);
search.update_button_visibility();
assert(search_button.prop('disabled'));
search_query.is = return_true;
search_query.val('');
narrow_state.active = return_false;
@ -62,7 +69,7 @@ run_test('update_button_visibility', () => {
assert(!search_button.prop('disabled'));
});
run_test('initizalize', () => {
run_test('initialize', () => {
const search_query_box = $('#search_query');
const searchbox_form = $('#searchbox_form');
const search_button = $('.search_button');
@ -135,6 +142,10 @@ run_test('initizalize', () => {
is_blurred = false;
is_append_search_string_called = false;
search_query_box.val(search_box_val);
Filter.parse = (search_string) => {
assert.equal(search_string, search_box_val);
return operators;
};
narrow.activate = (raw_operators, options) => {
assert.deepEqual(raw_operators, operators);
assert.deepEqual(options, {trigger: 'search'});
@ -150,7 +161,8 @@ run_test('initizalize', () => {
operand: 'ver',
}];
_setup('ver');
opts.updater('ver');
assert.equal(opts.updater('ver'), 'ver');
assert(!is_blurred);
assert(is_append_search_string_called);
@ -160,13 +172,15 @@ run_test('initizalize', () => {
operand: 'Verona',
}];
_setup('stream:Verona');
opts.updater('stream:Verona');
assert.equal(opts.updater('stream:Verona'), 'stream:Verona');
assert(!is_blurred);
assert(is_append_search_string_called);
search.is_using_input_method = true;
_setup('stream:Verona');
opts.updater('stream:Verona');
assert.equal(opts.updater('stream:Verona'), 'stream:Verona');
assert(!is_blurred);
assert(is_append_search_string_called);
}
@ -202,6 +216,10 @@ run_test('initizalize', () => {
is_blurred = false;
search_button.prop('disabled', false);
search_query_box.val(search_box_val);
Filter.parse = (search_string) => {
assert.equal(search_string, search_box_val);
return operators;
};
narrow.activate = (raw_operators, options) => {
assert.deepEqual(raw_operators, operators);
assert.deepEqual(options, {trigger: 'search'});
@ -211,7 +229,11 @@ run_test('initizalize', () => {
};
};
operators = [];
operators = [{
negated: false,
operator: 'search',
operand: '',
}];
_setup('');
ev.which = 15;
@ -233,11 +255,6 @@ run_test('initizalize', () => {
func(ev);
assert(is_blurred);
operators = [{
negated: false,
operator: 'search',
operand: 'ver',
}];
_setup('ver');
search.is_using_input_method = true;
func(ev);

4
frontend_tests/node_tests/search_legacy.js
View File

@ -26,7 +26,9 @@ run_test('update_button_visibility', () => {
search_query.is = return_false;
search_query.val('');
narrow_state.active = return_false;
search_button.prop('disabled', false);
search_button.prop('disabled', true);
search.update_button_visibility();
assert(search_button.prop('disabled'));
search_query.is = return_true;
search_query.val('');