From 9e76b3ef89ebb6ee97d4ea23c2a3b994efa5f1c6 Mon Sep 17 00:00:00 2001 From: Anders Kaseorg Date: Wed, 13 Nov 2024 01:51:57 -0800 Subject: [PATCH] test-js-with-node: Remove missing files from EXEMPT_FILES. Signed-off-by: Anders Kaseorg --- tools/test-js-with-node | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/tools/test-js-with-node b/tools/test-js-with-node index 1995d95b40..bd98f777f2 100755 --- a/tools/test-js-with-node +++ b/tools/test-js-with-node @@ -52,15 +52,12 @@ EXEMPT_FILES = make_set( "web/src/admin.js", "web/src/alert_popup.ts", "web/src/alert_words_ui.ts", - "web/src/archive.js", "web/src/assets.d.ts", "web/src/attachments.ts", "web/src/attachments_ui.ts", "web/src/audible_notifications.ts", "web/src/avatar.ts", "web/src/base_page_params.ts", - "web/src/billing/event_status.ts", - "web/src/billing/helpers.ts", "web/src/blueslip.ts", "web/src/blueslip_stacktrace.ts", "web/src/bootstrap_typeahead.ts", @@ -183,16 +180,13 @@ EXEMPT_FILES = make_set( "web/src/popover_menus.ts", "web/src/popover_menus_data.ts", "web/src/popovers.ts", - "web/src/popperjs.d.ts", "web/src/read_receipts.ts", - "web/src/ready.ts", "web/src/realm_icon.ts", "web/src/realm_logo.ts", "web/src/realm_playground.ts", "web/src/recent_view_ui.ts", "web/src/reload.ts", "web/src/reload_setup.js", - "web/src/reminder.js", "web/src/resize.ts", "web/src/resize_handler.ts", "web/src/rows.ts", @@ -263,7 +257,6 @@ EXEMPT_FILES = make_set( "web/src/todo_widget.ts", "web/src/topic_list.ts", "web/src/topic_popover.js", - "web/src/tutorial.js", "web/src/typing.ts", "web/src/typing_events.ts", "web/src/ui_init.js", @@ -285,7 +278,6 @@ EXEMPT_FILES = make_set( "web/src/user_group_edit.js", "web/src/user_group_edit_members.ts", "web/src/user_group_popover.ts", - "web/src/user_group_ui_updates.js", "web/src/user_groups.ts", "web/src/user_pill.ts", "web/src/user_profile.ts", @@ -298,7 +290,6 @@ EXEMPT_FILES = make_set( "web/src/views_util.ts", "web/src/zcommand.ts", "web/src/zform.js", - "web/src/zulip.js", "web/src/zulip_test.ts", "web/tests/lib/example_user.js", "web/tests/lib/mdiff.js", @@ -485,6 +476,8 @@ def enforce_proper_coverage(coverage_json: Any) -> bool: *glob.glob("web/tests/*.js"), *glob.glob("web/tests/lib/*.js"), } + missing_files = sorted(EXEMPT_FILES - all_js_files) + assert not missing_files, f"Missing files should be removed from EXEMPT_FILES: {missing_files}" enforce_fully_covered = sorted(all_js_files - EXEMPT_FILES) coverage_lost = False