Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

puppeteer_tests: Change `test_get_api_key` order to fix the flake. 

I tried different methods/strategies to find the reason for
this flake. But sadly I couldn't find the actual reason
for its failure.
(Read https://chat.zulip.org/#narrow/stream/43-automated-testing/topic/upgrading.20puppeteer.20to.209.2E1.2E1)

Somehow changing of test order i.e moving
`test_get_api_key` after `test_change_password` seems
to fix the flake.
This commit is contained in:
Riken Shah 2021-05-22 17:22:40 +00:00 committed by Tim Abbott
parent fe30cfe680
commit 9dcc94841a
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
frontend_tests/puppeteer_tests/settings.ts
View File

@ -62,7 +62,8 @@ async function test_change_password(page: Page): Promise<void> {
// when the above issue is resolved.
await page.waitForFunction(() => document.activeElement!.id === "change_password_modal");
await page.type("#old_password", test_credentials.default_user.password);
await page.type("#new_password", "new_password");
test_credentials.default_user.password = "new_password";
await page.type("#new_password", test_credentials.default_user.password);
await page.click(change_password_button_selector);
// On success the change password modal gets closed.
@ -384,8 +385,8 @@ async function settings_tests(page: Page): Promise<void> {
await common.log_in(page);
await open_settings(page);
await test_change_full_name(page);
await test_get_api_key(page);
await test_change_password(page);
await test_get_api_key(page);
await test_alert_words_section(page);
await test_your_bots_section(page);
await test_default_language_setting(page);