Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

portico: Don't use `dropdown-toggle` class. 

We want to avoid using `dropdown-toggle` class to avoid
properties leaking from bootstrap.
This commit is contained in:
Aman Agrawal 2024-01-12 12:16:57 +00:00 committed by Tim Abbott
parent 70ecdf2add
commit 9d1e977e2a
5 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
templates/corporate/communities.html
View File

@ -35,7 +35,7 @@
</div> </div>
<div class="integration-categories-dropdown"> <div class="integration-categories-dropdown">
<div class="dropdown-toggle"> <div class="integration-toggle-categories-dropdown">
<h3 class="dropdown-category-label">{% trans %}Filter by category{% endtrans %}</h3> <h3 class="dropdown-category-label">{% trans %}Filter by category{% endtrans %}</h3>
<i class="fa fa-angle-down" aria-hidden="true"></i> <i class="fa fa-angle-down" aria-hidden="true"></i>
</div> </div>

2
templates/zerver/integrations/index.html
View File

@ -43,7 +43,7 @@
</div> </div>
<div class="integration-categories-dropdown"> <div class="integration-categories-dropdown">
<div class="dropdown-toggle"> <div class="integration-toggle-categories-dropdown">
<h3 class="dropdown-category-label">{% trans %}Filter by category{% endtrans %}</h3> <h3 class="dropdown-category-label">{% trans %}Filter by category{% endtrans %}</h3>
<i class="fa fa-angle-down" aria-hidden="true"></i> <i class="fa fa-angle-down" aria-hidden="true"></i>
</div> </div>

9
web/src/portico/communities.ts
View File

@ -26,7 +26,10 @@ $(() => {
sync_open_organizations_page_with_current_hash(); sync_open_organizations_page_with_current_hash();
}); });
$(".integration-categories-dropdown .dropdown-toggle").on("click", () => { $(".integration-categories-dropdown .integration-toggle-categories-dropdown").on(
toggle_categories_dropdown(); "click",
}); () => {
toggle_categories_dropdown();
},
);
}); });

9
web/src/portico/integrations.js
View File

@ -315,9 +315,12 @@ function integration_events() {
} }
}); });
$(".integration-categories-dropdown .dropdown-toggle").on("click", () => { $(".integration-categories-dropdown .integration-toggle-categories-dropdown").on(
toggle_categories_dropdown(); "click",
}); () => {
toggle_categories_dropdown();
},
);
$(".integration-instruction-block").on("click", "a .integration-category", (e) => { $(".integration-instruction-block").on("click", "a .integration-category", (e) => {
e.preventDefault(); e.preventDefault();

2
web/styles/portico/integrations.css
View File

@ -227,7 +227,7 @@ $category-text: hsl(219deg 23% 33%);
padding: 12px 20px; padding: 12px 20px;
} }
.dropdown-toggle { .integration-toggle-categories-dropdown {
cursor: pointer; cursor: pointer;
display: flex; display: flex;
position: relative; position: relative;