Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

minor: Simplify maybe_add_narrowed_messages. 

We eliminate the messages_are_new parameter, which
was always set to `true`.
This commit is contained in:
Steve Howell 2019-01-08 00:28:01 +00:00 committed by Tim Abbott
parent 9893256668
commit 9a30b51e6e
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
static/js/message_events.js
View File

@ -2,7 +2,7 @@ var message_events = (function () {
var exports = {}; var exports = {};
function maybe_add_narrowed_messages(messages, msg_list, messages_are_new) { function maybe_add_narrowed_messages(messages, msg_list) {
var ids = []; var ids = [];
_.each(messages, function (elem) { _.each(messages, function (elem) {
ids.push(elem.id); ids.push(elem.id);
@ -41,7 +41,7 @@ function maybe_add_narrowed_messages(messages, msg_list, messages_are_new) {
message_util.add_messages( message_util.add_messages(
new_messages, new_messages,
msg_list, msg_list,
{messages_are_new: messages_are_new} {messages_are_new: true}
); );
unread_ops.process_visible(); unread_ops.process_visible();
notifications.notify_messages_outside_current_search(elsewhere_messages); notifications.notify_messages_outside_current_search(elsewhere_messages);
@ -52,7 +52,7 @@ function maybe_add_narrowed_messages(messages, msg_list, messages_are_new) {
if (msg_list === current_msg_list) { if (msg_list === current_msg_list) {
// Don't actually try again if we unnarrowed // Don't actually try again if we unnarrowed
// while waiting // while waiting
maybe_add_narrowed_messages(messages, msg_list, messages_are_new); maybe_add_narrowed_messages(messages, msg_list);
} }
}, 5000); }, 5000);
}}); }});
@ -77,7 +77,7 @@ exports.insert_new_messages = function insert_new_messages(messages, locally_ech
message_util.add_messages(messages, message_list.narrowed, {messages_are_new: true}); message_util.add_messages(messages, message_list.narrowed, {messages_are_new: true});
} else { } else {
// if we cannot apply locally, we have to wait for this callback to happen to notify // if we cannot apply locally, we have to wait for this callback to happen to notify
maybe_add_narrowed_messages(messages, message_list.narrowed, true); maybe_add_narrowed_messages(messages, message_list.narrowed);
} }
} else { } else {
// we're in the home view, so update its list // we're in the home view, so update its list